Make strict ODELIA swarm runs reliable and exact-client by default - #514
Draft
Ultimate-Storm wants to merge 2 commits into
Draft
Make strict ODELIA swarm runs reliable and exact-client by default#514Ultimate-Storm wants to merge 2 commits into
Ultimate-Storm wants to merge 2 commits into
Conversation
This was referenced Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
aggregator.accept()plus contribution hooks complete.--strict-clientsvalue derives mandatory clients, participating clients, and all quorum values;--min-*values opts into that custom/test policy.Why
Two independent production defects were reproduced.
In strict job
6e1d08b9, CAM's result reference had the default 1,800-second lifetime. It expired before MHA received serialized-submission permission at 1,881.55 seconds, so the first fetch returnedno ref foundand the round desynchronized. The producer TTL is controlled bydownload_complete_timeout, not tensor inactivity timeout.Canary
a8c6a75breported eight accepted contributions andFINISHED:COMPLETED, but actually loggedaggregating 7 update(s). The monitor observed the final trainer'sreply_timeand began aggregation whileaggregator.accept()was still processing UKA. The strict path now publishes that completion marker only after successful acceptance and event handling.The production policy is exact all-site participation. Retries preserve all eight; terminal site failure fails loudly. No pruning or partial continuation is introduced by this PR.
Impact
Future image builds contain the controller and six corrected job configurations. Future generated admin kits contain the strict-default helper and its matching patcher. Existing client identity/certificate kits do not need to be rebuilt merely to run a new image, but the new admin preparation behavior requires the updated helper/patcher (automatically included in newly generated admin kits).
Validation
1e4bface-91f8-460b-bcf0-2e14d60b5d72: exact eight started/finished, exactly eight accepted,aggregating 8 update(s), final broadcast to all peers, serverALL_DONE, no errors.87c5bbee-6f8b-41cb-bd37-e9625cbecee2: rounds 0–11 each aggregated exactly eight updates; round 12 remains healthy with all eight connected at the latest audit.378 passed, 7 skipped, 1 deselectedin the complete non-GPU unit suite; only pre-existing metric warnings.bash -nfor both modified shell scripts.git diff --check.jefftud/odelia:1.6.0constructor/config compatibility, includingdownload_complete_timeout.Closes #513.
Partially addresses #466.