docs(msrv): declare rust-version = 1.88#208
Merged
Merged
Conversation
The streaming reader (0.3.15, #206) uses a let-chain, stabilized in Rust 1.88, so 0.3.15 requires 1.88 even though edition 2024 alone only needs 1.85. Declare it via rust-version so cargo emits a clean 'requires rustc 1.88' error for consumers on 1.85-1.87 instead of a raw syntax error, and note the MSRV in the CHANGELOG. CI runs on stable so it did not surface the bump. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
0.3.15's streaming
readeruses a let-chain (stabilized in Rust 1.88), so the effective MSRV is 1.88 even though edition 2024 alone needs only 1.85. Declarerust-version = "1.88"so cargo gives consumers a clean version error rather than a raw syntax error, and note the MSRV bump in the CHANGELOG [0.3.15] section. No code change. (CI is stable-only, so it did not catch the bump.)Intended to land before publishing 0.3.15; the
v0.3.15tag will move onto the merge commit.🤖 Generated with Claude Code