Track cglobal load offsets in relocations - #905
Open
simeonschaub wants to merge 1 commit into
Open
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #905 +/- ##
==========================================
- Coverage 84.00% 83.60% -0.41%
==========================================
Files 28 28
Lines 5382 5421 +39
==========================================
+ Hits 4521 4532 +11
- Misses 861 889 +28 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Julia codegen references small-tagged DataTypes through constant offsets into jl_small_typeof. rewrite_word_loads! followed these expressions but discarded the offset, so nonzero entries resolved as the table's null first word. Carry byte offsets in CGlobalRef and use one relocation slot per symbol and offset. Reject nonconstant offsets instead of silently relocating the wrong word.
maleadt
force-pushed
the
sds/cglobal_relocations
branch
from
August 22, 2026 06:54
261d307 to
5ad6225
Compare
maleadt
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julia codegen references small-tagged datatypes through constant offsets into jl_small_typeof. Relocation collection followed these expressions but discarded the offset, causing nonzero entries to resolve as the table’s null first word.
Carry constant byte offsets in CGlobalRef, create one slot per symbol and offset, and reject nonconstant offsets rather than relocating the wrong word.