Give patchable relocation globals protected visibility. - #902
Merged
Conversation
Julia emits relocation globals `dso_local`, so backends address them
PC-relatively (`@rel32` on AMDGPU). `:patch` lowering defined them as
weak ODR with default visibility, which ELF treats as preemptible; lld
then rejects the `R_AMDGPU_REL32_*` relocations in AMDGPU.jl's `-shared`
link ("recompile with -fPIC").
Mark the record globals protected: non-preemptible, consistent with
`dso_local`, yet still in the dynamic symbol table so loaders (CUDA,
HIP, ORC) keep resolving them by name. NVPTX ignores visibility, and
JITLink/RuntimeDyld export STV_PROTECTED symbols like default ones.
Add a `patch` option to the GCN test helper and a regression test.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #902 +/- ##
=======================================
Coverage 84.01% 84.02%
=======================================
Files 28 28
Lines 5381 5382 +1
=======================================
+ Hits 4521 4522 +1
Misses 860 860 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Julia emits relocation globals
dso_local, so backends address them PC-relatively (@rel32on AMDGPU).:patchlowering defined them as weak ODR with default visibility, which ELF treats as preemptible; lld then rejects theR_AMDGPU_REL32_*relocations in AMDGPU.jl's-sharedlink ("recompile with -fPIC").Mark the record globals protected: non-preemptible, consistent with
dso_local, yet still in the dynamic symbol table so loaders (CUDA, HIP, ORC) keep resolving them by name. NVPTX ignores visibility, and JITLink/RuntimeDyld export STV_PROTECTED symbols like default ones.Add a
patchoption to the GCN test helper and a regression test.