[GCN] allow llvm.frexp and llvm.ldexp intrinsics - #900
Merged
Conversation
The ROCm device libraries (OCML) implement ldexp, pown, hypot, fmod,
cbrt, complex math etc. via the generic `llvm.frexp` and `llvm.ldexp`
intrinsics, which only exist since LLVM 17. On older LLVM versions
(Julia 1.10/1.11) `LLVMGetIntrinsicID` does not know them, so
`check_ir` rejected every kernel touching them with
InvalidIRError: unsupported call to an unknown function
(call to llvm.ldexp.f32.i32)
Final code generation handles them fine, so whitelist these two
intrinsic families for the GCN target.
Assisted-by: Claude Code (claude-fable-5)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #900 +/- ##
==========================================
- Coverage 84.04% 84.01% -0.04%
==========================================
Files 28 28
Lines 5379 5381 +2
==========================================
Hits 4521 4521
- Misses 858 860 +2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountered in JuliaGPU/AMDGPU.jl#1023. These intrinsics are not recognized by the older LLVM versions of Julia 1.10 and 1.11, so they resulted in an
InvalidIRError. They do occur in the more recent device libs though and the backend knows how to lower them, so accepts these as well