feat(core): implement security sandbox for template execution - #159
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
As Protostar transitions to allowing remote template execution (
protostar init --from <url>), it is critical to ensure that external templates cannot write files outside the project directory or invoke arbitrary shells. This PR implements a comprehensive security sandbox within theSystemExecutor.Changes
safe_extract_ziptofs.pyto prevent path traversal when extracting.ziparchives._enforce_path_jailto ensure all file injections and scaffolding directives are strictly confined to the workspace._enforce_binary_safelistto prevent execution of arbitrary shells and limit system tasks to a curated whitelist of safe binaries (uv,git,npm,yarn,pnpm,pre-commit,direnv).SecurityViolationErrorfor explicit vulnerability handling.