refactor(config): split ProtostarConfig into UserConfig and TemplateBlueprint - #158
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR resolves the "God Object" anti-pattern in
ProtostarConfigby separating global user configuration from template-specific scaffolding state.Architecture Changes
ProtostarConfigtoUserConfigto represent global, persistent settings (e.g.,ide,author_name, and tooling toggles).TemplateBlueprint: Encapsulates ephemeral, target-specific state (e.g.,active_presets,files,dev_dependencies, and template variables).Engine Updates
cli.py,orchestrator.py, andwizard.pyto independently ingest and handle bothUserConfigandTemplateBlueprintconfigurations across the scaffolding lifecycle.PresetModuleinterface inbase.pyfrom attempting to read a globalpresetsmapping that shouldn't exist, preventing attribute leakage.Testing & Validation
tests/(specificallytest_config.py,test_cli.py,test_orchestrator.py, andtest_presets.py).just test-unitcompletely passes, along withmypyandruffstatic analysis checks.