Updated ouroboros-network version, signature validation simplification#58
Open
coot wants to merge 16 commits into
Open
Updated ouroboros-network version, signature validation simplification#58coot wants to merge 16 commits into
coot wants to merge 16 commits into
Conversation
coot
force-pushed
the
coot/ouroboros-network-update
branch
2 times, most recently
from
81bab2d to
b4df916
Compare
Based on `coot/tracing-instances-1` branch from `ouroboros-network`. To use `main` branch we need to wait for `cardano-crypto-class`, `ouroboros-consensus`, `kes-agent-crypto` to support `contra-tracer-0.2.1.0`.
coot
force-pushed
the
coot/ouroboros-network-update
branch
6 times, most recently
from
a9b7b6f to
562f8ad
Compare
Removed the case where we validate signatures based on mark snapshot and we use set snapshot instead. Now signatures validation fails with `SigExipred` only in the `ZeroGoSnapshot` case. Because of that also the other case where `ssMarkSet` was used becomes obsolete, as a consequence we don't use the mark snapshot at all. If a pool reaches zero stake somewhere in epoch `i`, it will still mint blocks in epoch `i+1` as well. There's a natural inertia in the system based on trust in the stake. Using set snapshot makes minting signature compatible with minting blocks (the set snapshot is used for both). The check if a pool is eligible for generating a signature now becomes much simpler: we simply need to check if the pool has `NotZerGoSnapshot` or not, we don't need to depend on time in this check as we use data which is old enough to be available (e.g. the go snapshot comes from the beginning of two epoch prior the current one).
For the codec test we need to generate values via Word32, so no negative values nor fractional ones are generatated. Otherwise the round-trip property will not hold, since the codec is using `floor` function. In the previous commit the NominalDiffTime generator was changed, hence this change is required.
We need to sign `sigSignedBytes` not `sigBody`.
coot
force-pushed
the
coot/ouroboros-network-update
branch
from
562f8ad to
621be9c
Compare
We no longer need: * `c_MAX_CLOCK_SKEW_SEC` * next epoch time Instead we just provide a `TVar m Readiness`.
coot
force-pushed
the
coot/ouroboros-network-update
branch
from
621be9c to
238bfaf
Compare
Get the Praos max KES evolution from a Shelley genesis file.
The sig-submission size limits are now taking into account the `maxSigsInflight` (and `maxSigSize`).
Signed bytes are part of `SigRawWithSignedBytes`.
coot
force-pushed
the
coot/ouroboros-network-update
branch
from
238bfaf to
64c0775
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
List of changes
Updated to recent ouroboros-network
Based on
coot/tracing-instances-1branch fromouroboros-network.To use
mainbranch we need to wait forcardano-crypto-class,ouroboros-consensus,kes-agent-cryptoto supportcontra-tracer-0.2.1.0.signature validation: modification
Removed the case where we validate signatures based on mark set. Now
signatures validation fails with
SigExipredonly in theZeroSetSnapshotcase. Because of that also the other case wheressMarkSetwas used becomes obsolete, and thus we don't use the markset at all.
If a pool reaches zero stake in epoch
i, then it will still get rewardsin the epochs
i+1andi+2, so there's nothing wrong allowing it tomint signatures in the epoch
i+1, e.g. there's a natural inertia inthe system based on trust in the stake snapshots.
Added changelog entry
Checklist