Skip to content

Disable module autoload#86

Open
rzkhrv wants to merge 10 commits into
InterNACHI:mainfrom
rzkhrv:main
Open

Disable module autoload#86
rzkhrv wants to merge 10 commits into
InterNACHI:mainfrom
rzkhrv:main

Conversation

@rzkhrv

@rzkhrv rzkhrv commented Mar 29, 2024

Copy link
Copy Markdown

This change resolves the problem of autoloading files for modules that are not in the composer.json.

@inxilpro

inxilpro commented Apr 3, 2024

Copy link
Copy Markdown
Contributor

@rzkhrv can you explain why you would want this?

@rzkhrv

rzkhrv commented Apr 3, 2024

Copy link
Copy Markdown
Author

Hi @inxilpro, my case is when I remove a module from composer.json I get some errors...

@inxilpro

inxilpro commented Apr 6, 2024

Copy link
Copy Markdown
Contributor

Oh cool. Can you think of any reason this shouldn't just be the default? I don't know that we even need a config flag…

@rzkhrv

rzkhrv commented Apr 8, 2024

Copy link
Copy Markdown
Author

I don't have any reason, basically we can remove the config flag

@princejohnsantillan

Copy link
Copy Markdown

I agree. Feels like should be the default. I like this change.

rzkhrv added 2 commits April 27, 2024 18:26
# Conflicts:
#	config.php
#	src/Support/AutoDiscoveryHelper.php
@rzkhrv

rzkhrv commented Apr 27, 2024

Copy link
Copy Markdown
Author

Hi @inxilpro, I did it but my IDE doesn't want to format the code, can you help me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants