Skip to content

Make test suite parallel-safe by isolating console-dependent test behavior #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: dependabot/dotnet_sdk/dotnet-sdk-10.0.301
Choose a base branch
from
Draft

Make test suite parallel-safe by isolating console-dependent test behavior #262

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5b2188c
Disable test parallelization for console-output tests
Copilot Jun 12, 2026
14d96f9
Make console scan test safe for parallel runs
Copilot Jun 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions ListingManager.Tests/ConsoleOutputCollection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
using Xunit;

namespace EssentialCSharp.ListingManager.Tests;

[CollectionDefinition(Name, DisableParallelization = true)]
public sealed class ConsoleOutputCollection
{
public const string Name = "Console output collection";
}
30 changes: 25 additions & 5 deletions ListingManager.Tests/ScanManagerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
using IntelliTect.TestTools.Console;
using Xunit;
using Xunit;

namespace EssentialCSharp.ListingManager.Tests;

[Collection(ConsoleOutputCollection.Name)]
public class ScanManagerTests : TempFileTestBase
{
[Fact]
Expand All @@ -18,8 +18,11 @@ public void ScanForMissingTests()
Path.Join("Chapter02.Tests","Listing02.06.Something.Tests.cs")
};

const string expected = @"Missing test for 1.1
Missing test for 2.4";
List<string> expected = new()
{
"Missing test for 1.1",
"Missing test for 2.4"
};

List<string> toWrite =
[
Expand All @@ -37,6 +40,23 @@ public void ScanForMissingTests()
CreateTempDirectory(tempDir, "Chapter02.Tests");
WriteFiles(tempDir, filesToMake, toWrite);

ConsoleAssert.Expect(expected, () => ScanManager.ScanForAllMissingTests(tempDir, false));
TextWriter originalOut = Console.Out;
using StringWriter output = new();
try
{
Console.SetOut(output);
ScanManager.ScanForAllMissingTests(tempDir, false);
}
finally
{
Console.SetOut(originalOut);
}

List<string> actual = output.ToString()
.Split(Environment.NewLine, StringSplitOptions.RemoveEmptyEntries)
.OrderBy(line => line, StringComparer.Ordinal)
.ToList();

Assert.Equal(expected.OrderBy(line => line, StringComparer.Ordinal), actual);
}
}