Skip to content

Strip GCC-only -fno-merge-constants from flags in conda build#2978

Merged
antonwolfy merged 3 commits into
masterfrom
strip-gcc-no-merge-constants-flag
Jul 1, 2026
Merged

Strip GCC-only -fno-merge-constants from flags in conda build#2978
antonwolfy merged 3 commits into
masterfrom
strip-gcc-no-merge-constants-flag

Conversation

@antonwolfy

@antonwolfy antonwolfy commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

conda-forge's gcc/g++ compiler activation injects -fno-merge-constants into CFLAGS/CXXFLAGS when CONDA_BUILD==1.

The dpnp conda recipe builds with the Intel oneAPI compilers (icx/icpx), which do not implement this GCC flag and emit a warning on every compile unit:

icpx: command line warning #10430: Unsupported command line options encountered
These options as listed are not supported.
For more information, use '-qnextgen-diag'.
option list:
-fno-merge-constants

This PR removes -fno-merge-constants from CFLAGS/CXXFLAGS in conda-recipe/build.sh.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to an issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • Have you added documentation for your changes, if necessary?
  • Have you added your changes to the changelog?

@antonwolfy antonwolfy added this to the 0.21.0 release milestone Jun 29, 2026
@antonwolfy antonwolfy self-assigned this Jun 29, 2026
@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review June 29, 2026 12:59
@coveralls

coveralls commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Coverage Status

coverage: 78.107% (-0.002%) from 78.109% — strip-gcc-no-merge-constants-flag into master

@github-actions

github-actions Bot commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Array API standard conformance tests for dpnp=0.21.0dev2=py313h509198e_10 ran successfully.
Passed: 1370
Failed: 3
Skipped: 7

Comment thread conda-recipe/build.sh

@ndgrigorian ndgrigorian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonwolfy antonwolfy force-pushed the strip-gcc-no-merge-constants-flag branch from b8516f7 to 8396408 Compare July 1, 2026 15:33
@antonwolfy antonwolfy merged commit f60cdfe into master Jul 1, 2026
91 of 102 checks passed
@antonwolfy antonwolfy deleted the strip-gcc-no-merge-constants-flag branch July 1, 2026 18:12
github-actions Bot added a commit that referenced this pull request Jul 1, 2026
conda-forge's `gcc`/`g++` compiler activation injects
`-fno-merge-constants` into `CFLAGS`/`CXXFLAGS` when `CONDA_BUILD==1`.

The dpnp conda recipe builds with the Intel oneAPI compilers
(`icx`/`icpx`), which do not implement this GCC flag and emit a warning
on every compile unit:
```
icpx: command line warning #10430: Unsupported command line options encountered
These options as listed are not supported.
For more information, use '-qnextgen-diag'.
option list:
-fno-merge-constants
```

This PR removes `-fno-merge-constants` from `CFLAGS`/`CXXFLAGS` in
`conda-recipe/build.sh`. f60cdfe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants