-
Notifications
You must be signed in to change notification settings - Fork 0
feat: bare insta login signs in from the browser
#156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,70 @@ | ||
| // `login()` picks the flow from the flags; the injectable device runner (repo pattern: DI fakes, | ||
| // no global mocks) lets these tests pin the PUBLIC default — bare login = device grant + local | ||
| // browser opener — and the guard branches, without touching config or network. die() prints the | ||
| // reason to stderr and throws CliExit('exit 1'), so rejections assert 'exit 1' and the message | ||
| // is read from a captured stderr where it matters. | ||
| import { describe, expect, it } from 'vitest' | ||
| import { login, loginDevice } from '../src/commands/auth.js' | ||
| import { openUrl } from '../src/util.js' | ||
|
|
||
| type DeviceRunner = typeof loginDevice | ||
|
|
||
| function fakeDevice() { | ||
| const calls: Array<{ opts: unknown; open: unknown }> = [] | ||
| const run: DeviceRunner = async (opts, open) => { calls.push({ opts, open }) } | ||
| return { run, calls } | ||
| } | ||
|
|
||
| const mustNotRun: DeviceRunner = async () => { throw new Error('flow must not start') } | ||
|
|
||
| async function stderrOf(fn: () => Promise<unknown>): Promise<string> { | ||
| const lines: string[] = [] | ||
| const write = process.stderr.write.bind(process.stderr) | ||
| process.stderr.write = ((s: string) => { lines.push(String(s)); return true }) as typeof process.stderr.write | ||
| try { await fn() } finally { process.stderr.write = write } | ||
| return lines.join('') | ||
| } | ||
|
|
||
| describe('login dispatch', () => { | ||
| it('bare login rides the device grant with the local browser opener', async () => { | ||
| const prev = process.env.INSTA_PASSWORD | ||
| delete process.env.INSTA_PASSWORD // an ambient CI password must not divert the bare flow | ||
| try { | ||
| const { run, calls } = fakeDevice() | ||
| await login({}, run) | ||
| expect(calls).toHaveLength(1) | ||
| expect(calls[0].open).toBe(openUrl) | ||
| } finally { | ||
| if (prev !== undefined) process.env.INSTA_PASSWORD = prev | ||
| } | ||
| }) | ||
|
|
||
| it('--device is the same grant, print-only (no opener)', async () => { | ||
| const { run, calls } = fakeDevice() | ||
| await login({ device: true }, run) | ||
| expect(calls).toHaveLength(1) | ||
| expect(calls[0].open).toBeUndefined() | ||
| }) | ||
|
|
||
| it('a password without --email is rejected before any flow starts', async () => { | ||
| const err = await stderrOf(() => expect(login({ password: 'x' }, mustNotRun)).rejects.toThrow('exit 1')) | ||
| expect(err).toContain('only used with --email') | ||
| }) | ||
|
|
||
| it('$INSTA_PASSWORD without --email is rejected too', async () => { | ||
| const prev = process.env.INSTA_PASSWORD | ||
| process.env.INSTA_PASSWORD = 'hunter2' | ||
| try { | ||
| const err = await stderrOf(() => expect(login({}, mustNotRun)).rejects.toThrow('exit 1')) | ||
| expect(err).toContain('only used with --email') | ||
| } finally { | ||
| if (prev === undefined) delete process.env.INSTA_PASSWORD | ||
| else process.env.INSTA_PASSWORD = prev | ||
| } | ||
| }) | ||
|
|
||
| it('an explicitly empty --email is an error, not a bare browser login', async () => { | ||
| const err = await stderrOf(() => expect(login({ email: '' }, mustNotRun)).rejects.toThrow('exit 1')) | ||
| expect(err).toContain('--email must not be empty') | ||
| }) | ||
| }) |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.