CurrentTimeService: Initialize the whole current-time response - #2459
Open
JoeStrout wants to merge 1 commit into
Open
CurrentTimeService: Initialize the whole current-time response#2459JoeStrout wants to merge 1 commit into
JoeStrout wants to merge 1 commit into
Conversation
The read handler for the Current Time characteristic fills in seven of the nine fields of CtsCurrentTimeData. dayofweek and reason are never assigned, and the struct is a plain local, so those two bytes go out over the air as whatever was on the stack. dayofweek is the one that matters: it is a defined part of the characteristic, and a client reading the time gets a random day. Assign it from DateTime::DayOfWeek(), whose Days enum already matches the GATT encoding exactly (Unknown = 0, Monday = 1 ... Sunday = 7), so it casts directly like Month() on the line above. reason is an adjust-reason bit field with no bits to report here, so it is set to 0.
|
Build size and comparison to main:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The read handler for the Current Time characteristic fills in seven of the nine fields of CtsCurrentTimeData.
dayofweekandreasonare never assigned, and the struct is a plain local, so those two bytes go out over the air as whatever was on the stack.dayofweekis the one that matters: it is a defined part of the characteristic, and a client reading the time gets a random day. This PR assigns it fromDateTime::DayOfWeek(), whose Days enum already matches the GATT encoding exactly (Unknown = 0, Monday = 1 ... Sunday = 7), so it casts directly like Month() on the line above.reasonis an adjust-reason bit field with no bits to report here, so it is set to 0.