Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,17 @@ Use `GITHUB_TOKEN` or `GH_TOKEN` to avoid low GitHub API rate limits.

## Pull Request Guidelines

- Target all contribution pull requests to `main`.
- Do not target `release`; organization members use it only to promote a tested
`main` commit to production.
- Keep changes focused.
- Prefer Astro components in `src/components` over large page-only markup.
- Keep internal links compatible with GitHub Pages base paths by using `withBase()`.
- Run `npm run build` and include the result in the PR description.
- For content or roadmap changes, link the relevant issue or discussion.

## Production Release

The `release` branch is reserved for Cloudflare production deployments. Only
IndopenSource organization members may update it, through a pull request from
`main` that passes CI and receives approval.
9 changes: 6 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -63,16 +63,19 @@ URL produksi setelah custom domain aktif adalah `https://indopensource.org/`.

## Deployment

GitHub Pages memakai workflow `.github/workflows/deploy-pages.yml`.
Deployment saat ini masih memakai GitHub Pages melalui workflow
`.github/workflows/deploy-pages.yml`. Cloudflare production berikutnya akan
dibangun dari branch `release`.

- Build command: `npm run build`
- Output directory: `dist`
- Source: GitHub Actions
- Custom domain: `indopensource.org`
- Pages base path: `/`

Aktifkan Pages di repository settings dengan source `GitHub Actions`, lalu push ke
`main` atau jalankan workflow `Deploy to GitHub Pages` secara manual.
Semua kontribusi tetap masuk ke `main`. Rilis produksi dipromosikan oleh anggota
organisasi melalui pull request dari `main` ke `release`; jangan membuka pull
request kontribusi langsung ke `release`.
Comment on lines +76 to +78

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

There is a workflow discrepancy between the new release branch deployment model and the automated content sync.

Currently, the Auto Sync workflow (described in lines 95-107) automatically commits updated data to main and deploys it. If the production site on Cloudflare tracks the release branch, these automated updates (which run every 6 hours) will not appear on the production site until a manual pull request from main to release is created and merged.

To resolve this, consider updating the auto-sync workflow to also handle promotion to release, or document how these automated updates are expected to reach production.

Comment on lines +76 to +78

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Align release instructions with active deploy triggers

I checked the repo-defined deployment paths: .github/workflows/deploy-pages.yml still deploys GitHub Pages only on pushes to main (lines 3-6), and sync-content.yml deploys only when github.ref == 'refs/heads/main' (lines 116-123). In that current setup, following this new mainrelease promotion instruction would not trigger any deployment, while pushes to main still would, so the documented production release path contradicts the active workflows unless the deployment configuration is updated alongside it.

Useful? React with 👍 / 👎.


## Project Sync

Expand Down