ResultSet: Implement interface Countable - #169
Merged
Merged
Conversation
BastianLedererIcinga
requested changes
Aug 10, 2026
BastianLedererIcinga
requested changes
Aug 10, 2026
BastianLedererIcinga
approved these changes
Aug 11, 2026
nilmerg
force-pushed
the
feature/implement-countable-in-resultset-168
branch
from
August 11, 2026 06:52
3432482 to
dc933f9
Compare
nilmerg
added a commit
to Icinga/icinga-notifications-web
that referenced
this pull request
Aug 11, 2026
This adds `Incidents::getRoles(\Icinga\User $user): \Generator` that allows to fetch all incidents and roles for the given user. It's a convenience method as it allows to quickly determine the current role of said user and doesn't rely on the previously only available iteration over all incidents. An additional change, which should amplify the optimization benefit by this in Icinga/icingadb-web#1392 is that `Incidents::hasIncident()` does not always query all incidents now just to answer the question that *any* incident exists. requires Icinga/ipl-orm#169
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #168