Skip to content

feat(per): optional grouped CSV layout for ops-learning export (#2274) #2789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tarekchehahde wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

feat(per): optional grouped CSV layout for ops-learning export (#2274) #2789

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions per/custom_renderers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,9 @@ class NarrowCSVRenderer(PaginatedCSVRenderer):
Instead of this we would like to show these in different rows.
Maybe there is an easier way also to achieve this.
See also: admin.py::export_selected_records()

Used when exporting ops-learning CSV with ``?format=csv&csv_layout=narrow`` (default).
Use ``csv_layout=grouped`` for the standard wide/flattened CSV layout.
"""

def render(self, data, *args, **kwargs):
Expand Down
5 changes: 5 additions & 0 deletions per/drf_views.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1283,6 +1283,11 @@ class OpsLearningViewset(viewsets.ModelViewSet):
def get_renderers(self):
serializer = self.get_serializer()
if isinstance(serializer, OpsLearningCSVSerializer):
layout = self.request.GET.get("csv_layout", "narrow").lower()
if layout == "grouped":
from rest_framework_csv.renderers import PaginatedCSVRenderer

return [PaginatedCSVRenderer()]
return [NarrowCSVRenderer()]
return [renderer() for renderer in tuple(api_settings.DEFAULT_RENDERER_CLASSES)]

Expand Down