Fix Sector fixture assumptions in deployments tests (#2284)#2781
Open
Tarekchehahde wants to merge 1 commit into
Open
Fix Sector fixture assumptions in deployments tests (#2284)#2781Tarekchehahde wants to merge 1 commit into
Tarekchehahde wants to merge 1 commit into
Conversation
Stop relying on migration-seeded Sector/SectorTag rows by creating explicit test fixtures in ProjectGetTest and TranslationTest setUp. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SectorandSectorTaginstances inProjectGetTest.setUp()instead ofSector.objects.get(pk=…)against migration-seeded datatest_2,create_project, andTranslationTestto reference those fixturesiso3on test countries for consistency with other project testsFollows the approach discussed in #2284 and used on
feature/full-squash.Closes #2284
Test plan
docker-compose run --rm test pytest deployments/test_views.py::ProjectGetTest -qdocker-compose run --rm test pytest deployments/test_views.py::TranslationTest -qMade with Cursor