Skip to content

Track document downloads#2776

Open
szabozoltan69 wants to merge 5 commits into
developfrom
feature/doc-download-tracking
Open

Track document downloads#2776
szabozoltan69 wants to merge 5 commits into
developfrom
feature/doc-download-tracking

Conversation

@szabozoltan69

Copy link
Copy Markdown
Contributor

Refers to #2065 and to IFRCGo/go-web-app#750

@szabozoltan69 szabozoltan69 changed the title Track document downloads - v1 Track document downloads Jul 8, 2026

@susilnem susilnem left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, it looks good to me. Just some queries.

Comment thread analytics/serializers.py Outdated
Comment thread analytics/serializers.py Outdated
Comment thread analytics/admin.py Outdated

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we planning to run this Script manually?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, a cronjob setting will run it in a recurring time.

Comment thread analytics/models.py
Comment thread analytics/models.py
Comment thread analytics/models.py
choices=DocumentType.choices,
)
# PK of the source record – nullable for purely external documents
object_id = models.PositiveIntegerField(

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we check/verify this field?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not clear what you ask.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a simple check to see whether the object_id exists in our system or not.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This object_id can point to different systems. So it can be a duplicate one. Not clear yet the existence check.

@szabozoltan69

Copy link
Copy Markdown
Contributor Author

Thanksl, @susilnem , for the thorougful review and comments!

@szabozoltan69 szabozoltan69 force-pushed the feature/doc-download-tracking branch from 1a5047e to f295f69 Compare July 9, 2026 09:24
@szabozoltan69 szabozoltan69 requested a review from susilnem July 9, 2026 13:13
@szabozoltan69 szabozoltan69 force-pushed the feature/doc-download-tracking branch 2 times, most recently from 5757210 to 5fdcda1 Compare July 11, 2026 10:57
@szabozoltan69

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Jul 11, 2026

Copy link
Copy Markdown

@copilot resolve the merge conflicts in this pull request

Done. Merged develop into feature/doc-download-tracking and resolved the submodule (assets) conflict by using develop's version. The analytics app entry in main/settings.py was preserved throughout the merge — commit e159222.

@szabozoltan69 szabozoltan69 force-pushed the feature/doc-download-tracking branch from e159222 to 7ae9d8d Compare July 11, 2026 11:18
@szabozoltan69 szabozoltan69 force-pushed the feature/doc-download-tracking branch from 7ae9d8d to c9da6b0 Compare July 11, 2026 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants