-
Notifications
You must be signed in to change notification settings - Fork 11
Add Phase 5 cross-adapter verification suite (PR 18) #725
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
prk-Jr
wants to merge
31
commits into
feature/edgezero-pr17-cloudflare-adapter
Choose a base branch
from
feature/edgezero-pr18-phase5-verification
base: feature/edgezero-pr17-cloudflare-adapter
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
a499f93
Add Phase 5 verification plan for PR-18
prk-Jr ede4e81
Add route smoke tests for all Cloudflare adapter routes
prk-Jr acd3f5d
Fix rustfmt formatting in Cloudflare route smoke tests
prk-Jr 7efa2ff
Add basic-auth parity tests to Axum and Cloudflare adapters
prk-Jr 69d3693
Fix unwrap_or and comment inconsistency in basic-auth parity tests
prk-Jr 75fac49
Add admin key route full path coverage to Axum and Cloudflare adapters
prk-Jr e891f5e
Tighten storage-fail assertion and add duplicate context comments
prk-Jr 72be307
Add cross-adapter in-process parity test suite (Axum vs Cloudflare)
prk-Jr 4f79021
Fix parity test review issues: expect messages, dead if guard, unused…
prk-Jr 040a77b
Add error-correlation unit tests for PlatformResponse backend_name
prk-Jr 1e2979d
Add HTML rewriting golden tests, response size check, and Criterion b…
prk-Jr 0e4d2ea
Add criterion::black_box to benchmark input for measurement purity
prk-Jr 24f122f
Add cross-adapter parity and benchmark CI gates for Phase 5 verification
prk-Jr 99967c8
Add inline comment explaining -- --test flag in benchmark CI step
prk-Jr 8a509ac
Update Cargo.lock files after adding parity test dependencies
prk-Jr c114209
Pin axum/tower/tokio versions in integration-tests to match workspace
prk-Jr 84cbdfe
Pin tokio to exact workspace version =1.52.3 in integration-tests
prk-Jr 95fde69
Create parent directory before writing build output config
prk-Jr 0b2228c
Remove redundant wrong-credentials tests from admin key route coverage
prk-Jr fdef759
Fix admin_rotate_unauthenticated_parity: assert both adapters return 401
prk-Jr 5123bd4
Add clippy gate for integration-tests crate in test-parity CI job
prk-Jr 641bfde
Extract MAX_GROWTH_FACTOR constant in html_processor growth test
prk-Jr d7670aa
Fix trailing blank line in Cloudflare routes test file
prk-Jr b6a8894
Add clippy component to test-parity toolchain setup
prk-Jr a521479
Use multi_thread tokio flavor for all CF adapter route tests
prk-Jr 5f91da2
Add first-party route smoke tests to Axum adapter
prk-Jr c0f2eec
Strengthen parity test assertions for unauthenticated admin routes
prk-Jr 161c41e
Document tokio exact pin in integration-tests Cargo.toml
prk-Jr 70def67
Resolve PR 725 round-1 review findings
prk-Jr 254bd2e
Resolve PR review findings: strengthen test assertions and CI gate
prk-Jr 0be49bb
Merge feature/edgezero-pr17-cloudflare-adapter into PR18
prk-Jr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P0 / Blocker — New parity CI job is red
This command currently fails at HEAD. The new
[lints.clippy]block incrates/integration-tests/Cargo.tomlapplies to the whole excluded crate, and--all-targetsalso lints the pre-existingintegrationtarget. CI is failing on existing violations includingtests/common/ec.rs:309(collapsible_if),tests/frameworks/scenarios.rs:538and:728(redundant_closure_for_method_calls), andtests/integration.rs:205(clippy::panic).Why it matters: this PR cannot merge with the new required parity check failing.
Suggested fix: either fix those clippy violations, or if the intent is to gate only the new parity test target, narrow this to
cargo clippy --manifest-path crates/integration-tests/Cargo.toml --test parity -- -D warnings.