Skip to content

SCENARIO: Title of each glose that makes up a hexapla should be displayed (see #425).#430

Open
Flavien-Vidal wants to merge 3 commits into
mainfrom
fix-425
Open

SCENARIO: Title of each glose that makes up a hexapla should be displayed (see #425).#430
Flavien-Vidal wants to merge 3 commits into
mainfrom
fix-425

Conversation

@Flavien-Vidal

@Flavien-Vidal Flavien-Vidal commented May 26, 2026

Copy link
Copy Markdown
Contributor

Co-authored-by: Arthur de Pétigny ragxorus55@gmail.com

We, Flavien VIDAL, Arthur DE PETIGNY, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.

@benel

benel commented Jun 1, 2026

Copy link
Copy Markdown
Member

@Flavien-Vidal Thank you for your scenario and test step.
They seem to be OK. 👍🏼

Don't forget to use the Co-authored-by syntax in the commit description to mention your co-author (@ragxorus).

@benel benel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your updates @Flavien-Vidal and @ragxorus.

Don't forget to use the Co-authored-by syntax in the commit description to mention your co-author (@ragxorus).

Please note that:

  • the GitHub syntax requires angle brackets around e-mail adresses,
  • every commit should mention its co-author,
  • the commit itself don't have to include the license agreement (it is sufficient to put in the pull request conversation).

On a different matter, as you may have noticed, your tests failed. In the logs, it appears that you try to read a variable that is not defined:

https://github.com/Hypertopic/HyperGlosae/actions/runs/26828432218/job/79102495939?pr=430#step:5:224

@benel benel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the tests @gdosne.

@gdosne @Lysakolie @Flavien-Vidal

Please use git interactive rebase to rewrite the history so that there are only 3 commits (SCENARIO, TESTS, IMPROVEMENT).
Don't forget to use the Co-authored-by syntax in the commit description to mention the co-authors of each commit.

@benel benel force-pushed the main branch 3 times, most recently from 69f00a6 to 5c4b1c8 Compare June 15, 2026 13:10
@gd-utt gd-utt self-assigned this Jun 16, 2026
Flavien-Vidal and others added 3 commits June 16, 2026 14:31
…ayed (see #425).

Co-authored-by: Arthur DE PETIGNY <arthur@petigny.com>
… (see #425).

Co-authored-by: Arthur DE PETIGNY <arthur@petigny.com>
… (see #425).

Co-authored-by:Gabriel DOSNE gabriel.dosne@utt.fr

We, Gabriel DOSNE, Morgane VIALA, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants