SCENARIO: Title of each glose that makes up a hexapla should be displayed (see #425).#430
SCENARIO: Title of each glose that makes up a hexapla should be displayed (see #425).#430Flavien-Vidal wants to merge 3 commits into
Conversation
|
@Flavien-Vidal Thank you for your scenario and test step. Don't forget to use the |
There was a problem hiding this comment.
Thank you for your updates @Flavien-Vidal and @ragxorus.
Don't forget to use the Co-authored-by syntax in the commit description to mention your co-author (@ragxorus).
Please note that:
- the GitHub syntax requires angle brackets around e-mail adresses,
- every commit should mention its co-author,
- the commit itself don't have to include the license agreement (it is sufficient to put in the pull request conversation).
On a different matter, as you may have noticed, your tests failed. In the logs, it appears that you try to read a variable that is not defined:
https://github.com/Hypertopic/HyperGlosae/actions/runs/26828432218/job/79102495939?pr=430#step:5:224
benel
left a comment
There was a problem hiding this comment.
Thank you for fixing the tests @gdosne.
@gdosne @Lysakolie @Flavien-Vidal
Please use git interactive rebase to rewrite the history so that there are only 3 commits (SCENARIO, TESTS, IMPROVEMENT).
Don't forget to use the Co-authored-by syntax in the commit description to mention the co-authors of each commit.
69f00a6 to
5c4b1c8
Compare
…ayed (see #425). Co-authored-by: Arthur DE PETIGNY <arthur@petigny.com>
… (see #425). Co-authored-by: Arthur DE PETIGNY <arthur@petigny.com>
… (see #425). Co-authored-by:Gabriel DOSNE gabriel.dosne@utt.fr We, Gabriel DOSNE, Morgane VIALA, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses
Co-authored-by: Arthur de Pétigny ragxorus55@gmail.com
We, Flavien VIDAL, Arthur DE PETIGNY, hereby grant to Hyperglosae maintainers the right to publish our contribution under the terms of any licenses the Free Software Foundation classifies as Free Software Licenses.