fix(puter-js): guard PWispHandler against unknown stream ids - #3474
Open
Ayush7614 wants to merge 1 commit into
Open
fix(puter-js): guard PWispHandler against unknown stream ids#3474Ayush7614 wants to merge 1 commit into
Ayush7614 wants to merge 1 commit into
Conversation
DATA/CONTINUE/CLOSE frames for missing streamMap entries null-dereferenced and crashed the shared relay onmessage handler. Ignore unknown streams instead of assuming the entry exists.
Collaborator
|
@r58Playz can you review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DATA/CONTINUE/CLOSEframes for missingstreamMapentries null-dereferenced and crashed the shared Wisp relayonmessagehandler.Why this is real
Late/duplicate frames after close, or hostile stream ids, could take down every socket sharing that Wisp connection.
Test plan
vitest run src/puter-js/src/modules/networking/PWispHandler.test.js— 10 passed