Add disable culling option - #545
Open
Pizzabucket wants to merge 14 commits into
Open
Conversation
Author
|
Sorry for the last update. I broke the fading effect and the fixed hud models on the last one. |
Contributor
|
I'm going to be thorough in the review here, so don't take offense to anything. It's all for your information so you can improve. Thanks again for contributing some changes that could only be tested on unique hardware. First, the PR description doesn't match the diff. "Fixes the scaling of 3D HUD objects at different aspect ratios" is claimed, but there's no scaling changes anywhere in the nine files. Either it was mistakenly dropped, or removed intentionally to be a separate, smaller pull request (which would be preferred anyway). Second, you should cleanup your code before expecting a line-level review. Some examples:
|
Pizzabucket
marked this pull request as draft
August 25, 2026 03:43
Pizzabucket
force-pushed
the
disable-culling-option
branch
from
August 26, 2026 21:05
7bf5d69 to
792e3f7
Compare
Pizzabucket
marked this pull request as ready for review
August 26, 2026 21:07
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Credits
Parts of the demo/playback synchronization approach were adapted from BanjoRecomp.
Build Artifacts