feat(asm): complete Tags resource — add GET, PATCH, DELETE /tags/{tag_id}#22
Open
dmchaledev wants to merge 1 commit into
Open
feat(asm): complete Tags resource — add GET, PATCH, DELETE /tags/{tag_id}#22dmchaledev wants to merge 1 commit into
dmchaledev wants to merge 1 commit into
Conversation
The Tags resource was missing single-resource operations that every other
resource (Assets, Vulnerabilities) already exposes. Adds GET /tags/{tag_id},
PATCH /tags/{tag_id}, and DELETE /tags/{tag_id}, plus the TagId path
parameter, TagUpdate request schema, and descriptions on listTags/createTag.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NiDvq31B2krChD32LkopDV
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
Tagsresource inasm/openapi.yamlwas incomplete. Developers could list all tags (GET /tags) and create a tag (POST /tags), but had no way to:Every other resource in the spec (Assets, Vulnerabilities) already exposes a full single-resource path with GET, PATCH, and DELETE. Tags were the odd one out, which would confuse API consumers and make tag lifecycle management impossible without a round-trip list.
Changes
asm/openapi.yaml(+79 lines, no deletions):GET /tags/{tag_id}PATCH /tags/{tag_id}nameand/orcolorDELETE /tags/{tag_id}components/parameters/TagIdtag_idpath parameter (mirrorsAssetId)components/schemas/TagUpdatelistTagsdescriptiondescriptionfieldcreateTagdescriptiondescriptionfieldAll new operations follow the exact same patterns already established by the Assets and Vulnerabilities resources (shared error responses, operationId naming, tag grouping).
Test plan
spectral lint asm/openapi.yaml --ruleset spectral:oaspasses (validated by the existing CI workflow)GET /tags/{tag_id}renders correctly in the Redoc previewPATCH /tags/{tag_id}showsTagUpdaterequest body schemaDELETE /tags/{tag_id}shows204 No Contentresponse🤖 Generated with Claude Code
https://claude.ai/code/session_01NiDvq31B2krChD32LkopDV
Generated by Claude Code