You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Nice work! The DAG is clear and complete: monthly schedule, catchup=False, max_active_runs=1, retries, logical-date partitioning with a month filter, and a strict ingest and dbt run and dbt_test chain. The backfill evidence (7 green runs + matching before/after counts) and screenshots look good.
Small cleanups:
in ASSIGNMENT_REPORT.md, the shared-deploy section still points at a local run screenshot / an assignment-repo PR URL. If you did deploy to shared Airflow, swap those for the namespaced DAG run + merged shared PR; if the VM was offline, just note that.
in the report SQL, replace airflow_<my_role> with the schema you actually queried. Score: 100/100
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What I built
dags/taxi_pipeline.pyingest_taxi_month → dbt_run → dbt_testcatchup=Falseinclude/dbt_project/RUNBOOK.mdASSIGNMENT_REPORT.mdAI_ASSIST.mdevidence/folderHow to review
dags/taxi_pipeline.pyRUNBOOK.mdASSIGNMENT_REPORT.mdAI_ASSIST.mdevidence/How to run
From a clean clone, with Docker Desktop and the Astro CLI installed:
Create the
azure_pgconnection in the Airflow UI:Admin → ConnectionsThen run the DAG integrity test:
For a manual run, open
taxi_pipeline, click Trigger, and use:{ "target_date": "2024-01-01" }To run the seven-month backfill:
To repeat the backfill for the idempotency check:
What reviewers should see
ingest_taxi_month → dbt_run → dbt_testdbt_rundbt_testevidence/folderTest results
test_dag_integrity.py: all tests passedShared Airflow deployment
Shared Airflow deployment: https://github.com/lassebenni/c55-shared-airflow/pull/10/changes
Known limitations / out of scope
Self-check
bash .hyf/test.shpassesastro dev pytest tests/test_dag_integrity.py --args "-v"passescatchup=Falseis configuredRUNBOOK.mdis completedAI_ASSIST.mdis completedASSIGNMENT_REPORT.mdis completed