修复多语言资源缺失、占位符错误与本地构建依赖路径问题喵#6183
Open
ShadowLoveElysia wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
本次 PR 主要修复了一些低风险但会影响用户体验的小细节问题喵~
改动集中在多语言资源文件和一个本地构建脚本上,没有改动 Minecraft 启动主流程、账号系统、下载核心或版本管理逻辑
这是修复内容秒
修复了西班牙语资源文件中的 .properties 续行格式问题
修复了 Cleanroom 启动建议文案中 Java 版本被写死的问题(原文案固定写成 Java 21,但代码实际会传入动态的最低 Java 版本和Cleanroom 版本,现在改为使用 %1$s 和 %2$s 占位符,这样之后 Cleanroom 的最低 Java 要求变化时,提示内容也能跟着实际参数正确显示,不会误导用户啦喵)
修复了乌克兰语资源文件中的 key 拼接错误(
原来的 key 是:
launch.failed.creating_processlaunch.advice
现在修正为:
launch.failed.creating_process)
这个问题会导致乌克兰语环境下 “无法创建进程,请检查 Java 路径” 的启动失败提示无法被正确匹配,修复后,对应错误场景可以显示正确翻译喵
修复了 HMCLTransformerDiscoveryService 的本地依赖引用方式
路径 minecraft/libraries/HMCLTransformerDiscoveryService/build.gradle.kts
将
compileOnly(project.files("lib/modlauncher-4.1.0.jar"))
调整为
compileOnly(files("lib/modlauncher-4.1.0.jar"))
这个改动可以让该子项目在完整 :HMCL:jar 构建链路中更稳定地解析本地的 modlauncher-4.1.0.jar,避免本地完整打包时出现编译 classpath 找不到依赖的问题喵
此次PR修改已进行编译测试,编译通过且已经过人工测试