Jenkins docker support - #139
Open
prestoncraw wants to merge 15 commits into
Open
Conversation
clackner-gpa
requested changes
Aug 10, 2026
| <Description></Description> | ||
| <Company>GridProtectionAlliance</Company> | ||
| <Product>SEBrowser</Product> | ||
| <Copyright>Copyright © 2020</Copyright> |
Member
There was a problem hiding this comment.
Suggested change
| <Copyright>Copyright © 2020</Copyright> | |
| <Copyright>Copyright © 2026</Copyright> |
| <AssemblyTitle>SEBrowser</AssemblyTitle> | ||
| <Description></Description> | ||
| <Company>GridProtectionAlliance</Company> | ||
| <Product>SEBrowser</Product> |
Member
There was a problem hiding this comment.
Suggested change
| <Product>SEBrowser</Product> | |
| <Product>PQBrowser</Product> |
| </PropertyGroup> | ||
| <PropertyGroup> | ||
| <TargetFramework>net9.0</TargetFramework> | ||
| <AssemblyTitle>SEBrowser</AssemblyTitle> |
Member
There was a problem hiding this comment.
Suggested change
| <AssemblyTitle>SEBrowser</AssemblyTitle> | |
| <AssemblyTitle>PQBrowser</AssemblyTitle> |
| NUGET_PACKAGES = "D:\\NuGetCache" | ||
| publishDirectory = "${WORKSPACE}\\build\\Jenkins\\publish" | ||
| artifactDirectory = "${WORKSPACE}\\build\\Jenkins\\artifacts" | ||
| deliveryDirectory = "\\\\webhostfiles\\Delivery\\SEBrowser" |
Member
There was a problem hiding this comment.
Suggested change
| deliveryDirectory = "\\\\webhostfiles\\Delivery\\SEBrowser" | |
| deliveryDirectory = "\\\\webhostfiles\\Delivery\\PQBrowser" |
| script { | ||
| // Set current Version | ||
| def fileContent = powershell(returnStdout: true, script: ''' | ||
| Get-Content -Path "./Scripts/SEBrowser.version" -Raw |
Member
There was a problem hiding this comment.
Suggested change
| Get-Content -Path "./Scripts/SEBrowser.version" -Raw | |
| Get-Content -Path "./Scripts/PQBrowser.version" -Raw |
| } | ||
| steps { | ||
| script { | ||
| env.seBrowserDockerTag = env.CHANGE_BRANCH == "${env.devBranch}" ? "${env.seBrowserVersion}a" : env.seBrowserVersion |
Member
There was a problem hiding this comment.
Suggested change
| env.seBrowserDockerTag = env.CHANGE_BRANCH == "${env.devBranch}" ? "${env.seBrowserVersion}a" : env.seBrowserVersion | |
| env.pqBrowserDockerTag = env.CHANGE_BRANCH == "${env.devBranch}" ? "${env.pqBrowserVersion}a" : env.pqBrowserVersion |
Comment on lines
+205
to
+207
|
|
||
| powershell "msbuild /t:Publish /p:DeployOnBuild=true';'Configuration=Release';'PublishProfile='Docker Release Profile SEBrowser' './SEBrowser/SEBrowser.csproj' /nodeReuse:false -restore" | ||
| powershell "docker build --build-arg CONFIGURATION=Release -f .\\SEBrowser.dockerfile -t sebrowser:${env.seBrowserDockerTag} ." |
Member
There was a problem hiding this comment.
Suggested change
| powershell "msbuild /t:Publish /p:DeployOnBuild=true';'Configuration=Release';'PublishProfile='Docker Release Profile SEBrowser' './SEBrowser/SEBrowser.csproj' /nodeReuse:false -restore" | |
| powershell "docker build --build-arg CONFIGURATION=Release -f .\\SEBrowser.dockerfile -t sebrowser:${env.seBrowserDockerTag} ." | |
| powershell "msbuild /t:Publish /p:DeployOnBuild=true';'Configuration=Release';'PublishProfile='Docker Release Profile PQBrowser' './PQBrowser/PQBrowser.csproj' /nodeReuse:false -restore" | |
| powershell "docker build --build-arg CONFIGURATION=Release -f .\\PQBrowser.dockerfile -t pqbrowser:${env.pqBrowserDockerTag} ." |
| Remove-Item -LiteralPath '${env.publishDirectory}' -Recurse -Force | ||
| } | ||
| New-Item -ItemType Directory -Path '${env.publishDirectory}' -Force | Out-Null | ||
| dotnet publish '.\\SEBrowser\\SEBrowser.csproj' ` |
Member
There was a problem hiding this comment.
Suggested change
| dotnet publish '.\\SEBrowser\\SEBrowser.csproj' ` | |
| dotnet publish '.\\PQBrowser\\PQBrowser.csproj' ` |
Comment on lines
+228
to
+231
| '${env.publishDirectory}\\SEBrowser.exe', | ||
| '${env.publishDirectory}\\SEBrowser.dll', | ||
| '${env.publishDirectory}\\package.json', | ||
| '${env.publishDirectory}\\wwwroot\\Scripts\\SEBrowser.${env.uiVersion}.js' |
Member
There was a problem hiding this comment.
Suggested change
| '${env.publishDirectory}\\SEBrowser.exe', | |
| '${env.publishDirectory}\\SEBrowser.dll', | |
| '${env.publishDirectory}\\package.json', | |
| '${env.publishDirectory}\\wwwroot\\Scripts\\SEBrowser.${env.uiVersion}.js' | |
| '${env.publishDirectory}\\PQBrowser.exe', | |
| '${env.publishDirectory}\\PQBrowser.dll', | |
| '${env.publishDirectory}\\package.json', | |
| '${env.publishDirectory}\\wwwroot\\Scripts\\PQBrowser.${env.uiVersion}.js' |
clackner-gpa
requested changes
Aug 12, 2026
| # Copy PQBrowser from the local published folder to the container | ||
| COPY ./[Bb]uild/${CONFIGURATION}/Applications/PQBrowser/net9.0/publish/linux-x64/ /PQBrowser/ | ||
|
|
||
| ENV ASPNETCORE_HTTP_PORTS=8001 |
Member
There was a problem hiding this comment.
Suggested change
| ENV ASPNETCORE_HTTP_PORTS=8001 |
Comment on lines
+199
to
+202
| if (Test-Path -LiteralPath '${env.publishDirectory}') { | ||
| Remove-Item -LiteralPath '${env.publishDirectory}' -Recurse -Force | ||
| } | ||
| New-Item -ItemType Directory -Path '${env.publishDirectory}' -Force | Out-Null |
Member
There was a problem hiding this comment.
Suggested change
| if (Test-Path -LiteralPath '${env.publishDirectory}') { | |
| Remove-Item -LiteralPath '${env.publishDirectory}' -Recurse -Force | |
| } | |
| New-Item -ItemType Directory -Path '${env.publishDirectory}' -Force | Out-Null |
Contributor
Author
There was a problem hiding this comment.
Why do we want to remove this?
| New-Item -ItemType Directory -Path '${env.publishDirectory}' -Force | Out-Null | ||
| dotnet publish '.\\PQBrowser\\PQBrowser.csproj' ` | ||
| '-p:PublishProfile=Release Profile PQBrowser' ` | ||
| -o '${env.publishDirectory}' |
Member
There was a problem hiding this comment.
Suggested change
| -o '${env.publishDirectory}' |
that should be defined in profile
Comment on lines
+19
to
+20
| publishDirectory = "${WORKSPACE}\\build\\Jenkins\\publish" | ||
| artifactDirectory = "${WORKSPACE}\\build\\Jenkins\\artifacts" |
Member
There was a problem hiding this comment.
Suggested change
| publishDirectory = "${WORKSPACE}\\build\\Jenkins\\publish" | |
| artifactDirectory = "${WORKSPACE}\\build\\Jenkins\\artifacts" |
neither should matter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
development→masterprereleases andmasterreleases, including submodule checkout.\\webhostfiles\Delivery\SEBrowserdirectories, comment prerelease availability on the development PR, and tag qualifying releases.Scripts/SEBrowser.versionas the single three-part version source and remove the legacyAssemblyInfo.csversion attributes.8001.DisableAuthenticationsetting and middleware.package.jsonand display the UI version in the application.Jenkins publishing and delivery-share operations were not executed during local validation.