PQB-115 - #37
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the SOE/ITOA event widgets to support dynamic SQL-driven result sets and aligns the SOE widget with an updated backend route signature that includes widgetID (per the noted dependency). It also introduces a shared DynamicSQLResultsTable component to render arbitrary SQL result shapes without hardcoding columns.
Changes:
- Added
DynamicSQLResultsTableto renderDynamicSQLRow[]with dynamically generated columns. - Updated SOE and ITOA widgets to use
DynamicSQLResultsTableand to consumeDynamicSQLRow[]from the API. - Updated SOE API route and frontend request to include
{widgetID:int}; added SOESQLCommandsetting UI.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| TSX/Widget/SOE.tsx | Adds SQLCommand setting UI, switches to dynamic results table, and updates SOE request to include widgetID. |
| TSX/Widget/ITOA.tsx | Switches ITOA rendering to the shared dynamic results table and uses DynamicSQLRow[]. |
| TSX/Widget/DynamicSQLResultsTable.tsx | New shared component to render arbitrary SQL result rows as a table. |
| API/Model/SOEController.cs | Updates SOE GET route to accept widgetID and forwards the request. |
Suppressed comments (2)
TSX/Widget/ITOA.tsx:145
- This container sets
overflowY: 'hidden'while also constraining height (maxHeight: resultsMaxHeight). That will clip the loading spinner (height: 250) and any content that exceeds the max height without providing a way to scroll. UseoverflowY: 'auto'(or remove the maxHeight constraint) to keep overflow content accessible.
<div style={{ maxHeight: resultsMaxHeight, overflowY: 'hidden' }}>
TSX/Widget/SOE.tsx:208
- This container sets
overflowY: 'hidden'while also constraining height (maxHeight: resultsMaxHeight). That will clip the loading spinner (height: 250) and any content that exceeds the max height without providing a way to scroll. UseoverflowY: 'auto'(or remove the maxHeight constraint) to keep overflow content accessible.
<div style={{ maxHeight: resultsMaxHeight, overflowY: 'hidden' }}>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
elwills
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends On: