Skip to content

PQB-115 - #37

Merged
prestoncraw merged 2 commits into
mainfrom
SOE_ConfigurableQuery
Aug 7, 2026
Merged

PQB-115#37
prestoncraw merged 2 commits into
mainfrom
SOE_ConfigurableQuery

Conversation

@prestoncraw

@prestoncraw prestoncraw commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Depends On:

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the SOE/ITOA event widgets to support dynamic SQL-driven result sets and aligns the SOE widget with an updated backend route signature that includes widgetID (per the noted dependency). It also introduces a shared DynamicSQLResultsTable component to render arbitrary SQL result shapes without hardcoding columns.

Changes:

  • Added DynamicSQLResultsTable to render DynamicSQLRow[] with dynamically generated columns.
  • Updated SOE and ITOA widgets to use DynamicSQLResultsTable and to consume DynamicSQLRow[] from the API.
  • Updated SOE API route and frontend request to include {widgetID:int}; added SOE SQLCommand setting UI.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
TSX/Widget/SOE.tsx Adds SQLCommand setting UI, switches to dynamic results table, and updates SOE request to include widgetID.
TSX/Widget/ITOA.tsx Switches ITOA rendering to the shared dynamic results table and uses DynamicSQLRow[].
TSX/Widget/DynamicSQLResultsTable.tsx New shared component to render arbitrary SQL result rows as a table.
API/Model/SOEController.cs Updates SOE GET route to accept widgetID and forwards the request.
Suppressed comments (2)

TSX/Widget/ITOA.tsx:145

  • This container sets overflowY: 'hidden' while also constraining height (maxHeight: resultsMaxHeight). That will clip the loading spinner (height: 250) and any content that exceeds the max height without providing a way to scroll. Use overflowY: 'auto' (or remove the maxHeight constraint) to keep overflow content accessible.
                    <div style={{ maxHeight: resultsMaxHeight, overflowY: 'hidden'  }}>

TSX/Widget/SOE.tsx:208

  • This container sets overflowY: 'hidden' while also constraining height (maxHeight: resultsMaxHeight). That will clip the loading spinner (height: 250) and any content that exceeds the max height without providing a way to scroll. Use overflowY: 'auto' (or remove the maxHeight constraint) to keep overflow content accessible.
                    <div style={{ maxHeight: resultsMaxHeight, overflowY: 'hidden' }}>

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread TSX/Widget/SOE.tsx
Comment thread TSX/Widget/ITOA.tsx
Comment thread TSX/Widget/DynamicSQLResultsTable.tsx
@prestoncraw
prestoncraw merged commit 4a305c2 into main Aug 7, 2026
2 checks passed
@prestoncraw
prestoncraw deleted the SOE_ConfigurableQuery branch August 7, 2026 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants