fix: support digits in clan chat names + optional default clan chat for new players#1027
Merged
Merged
Conversation
…ault clan chat on new player joins.
GregHib
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
Clan names containing digits were broken: writeLong(String) in JagExtensions.kt encoded names as base-37 RS longs but checked digit characters against in 0..9 instead of their ASCII codes (48..57), so digits were silently dropped.
One-line fix to the character range; the - 21 offset was already correct ('0' → 27 … '9' → 36).
Features
Added an optional world.start.clanChat setting (game.properties). When set to a channel owner's display name, brand-new accounts automatically join that clan chat on first login. Detection uses the transient new_player flag set by
AccountManager.create(), so it is unaffected by script ordering or the world.start.creation setting. Bots are excluded, and the join persists via the existing clan_chat variable (normal auto-rejoin/leave behaviour applies).
Tests