NavyaAilaS225272001/fix/messages-keyboard-shortcuts - #503
Conversation
Added keyboard shortcuts for search, filter actions, and message deletion. Included a visual indicator for available shortcuts.
|
Nice idea, and the shortcuts hint bar is a good touch. A few things to rework before merge, though: The hook drives everything through the DOM — querySelectorAll('button') + textContent === 'Cancel'/'Delete' + .click(), and querySelector('input[placeholder*="Type a name"]'). That's fragile (breaks on any label/placeholder change or i18n) and this component already has the real handlers to call. Could we: Use a ref on the search input instead of a placeholder query. Happy to re-review once it's using refs/handlers instead of DOM scraping. A short clip of the shortcuts working would be great as evidence too. |
|
Thank you for the quick review, i have gone ahead and implemented the changes and included a clip showing the shortcuts are working in the message page. Could you please review it and approve the PR. Thank you! |










Added keyboard shortcuts for search, filter actions, and message deletion. Indicator is also there for available shortcuts.