Fix /myshifts route being incorrectly matched as shift ID - #499
Open
AngeloZois wants to merge 1 commit into
Open
Fix /myshifts route being incorrectly matched as shift ID#499AngeloZois wants to merge 1 commit into
AngeloZois wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where the Employer Dashboard was unable to load shifts because the
/api/v1/shifts/myshiftsendpoint was being incorrectly handled by the dynamic/:idroute.Problem
When the Employer Dashboard requested
/api/v1/shifts/myshifts, Express matchedmyshiftsas the:idparameter. The backend then attempted to validatemyshiftsas a MongoDB ObjectId and returned a400 Invalid idresponse.Fix
Moved the
/myshiftsroute above the/:idroute inshift.routes.jsso the specific route is matched before the dynamic ID route.Testing
/myshiftsnow loads successfully.Invalid iderror.