Skip to content

refactor(gae): remove region tags from datastore inequality filters - #10319

Merged
Kef131 merged 1 commit into
GoogleCloudPlatform:mainfrom
Kef131:refactor(gae)-remove-unused-region-tags-datastore-queries
Jul 30, 2026
Merged

refactor(gae): remove region tags from datastore inequality filters#10319
Kef131 merged 1 commit into
GoogleCloudPlatform:mainfrom
Kef131:refactor(gae)-remove-unused-region-tags-datastore-queries

Conversation

@Kef131

@Kef131 Kef131 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Fixes

b/347351984

Description

Refactor Datastore queries test by removing redundant and unused snippet region tags (gae_java8_datastore_inequality_filters_one_property_valid_1, gae_java8_datastore_inequality_filters_one_property_invalid, gae_java8_datastore_inequality_filters_one_property_valid_2) in appengine-java8/datastore/src/test/java/com/example/appengine/QueriesTest.java.

Checklist

Testing

  • I have tested this change on a live environment and verified it works as intended.
  • Tests pass: mvn clean verify required
  • Lint passes: mvn -P lint checkstyle:check required
  • Static Analysis: mvn -P lint clean compile pmd:cpd-check spotbugs:check advisory only

Compliance & Style

  • I have followed Sample Format Guide
  • pom.xml parent set to latest shared-configuration
  • Appropriate changes to README are included in PR
  • This sample adds a new sample directory, and I updated the CODEOWNERS file with the codeowners for this sample
  • This sample adds a new Product API, and I updated the Blunderbuss issue/PR auto-assigner with the codeowners for this sample

Post-Approval Actions

  • Please merge this PR for me once it is approved

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: appengine Issues related to the App Engine Admin API API. labels Jul 29, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes several Google App Engine documentation snippet tags (such as [START ...] and [END ...]) from the QueriesTest.java test file. There are no review comments, and I have no feedback to provide.

@amcolin
amcolin marked this pull request as ready for review July 29, 2026 23:01
@amcolin
amcolin requested review from a team and yoshi-approver as code owners July 29, 2026 23:01
@snippet-bot

snippet-bot Bot commented Jul 29, 2026

Copy link
Copy Markdown

Here is the summary of changes.

You are about to delete 3 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@XrossFox XrossFox left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kef131
Kef131 merged commit 11dc6b9 into GoogleCloudPlatform:main Jul 30, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: appengine Issues related to the App Engine Admin API API. samples Issues that are directly related to samples.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants