refactor(gae): remove region tags from datastore inequality filters - #10319
Merged
Kef131 merged 1 commit intoJul 30, 2026
Conversation
amcolin
marked this pull request as ready for review
July 29, 2026 23:01
|
Here is the summary of changes. You are about to delete 3 region tags.
This comment is generated by snippet-bot.
|
amcolin
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
b/347351984
Description
Refactor Datastore queries test by removing redundant and unused snippet region tags (
gae_java8_datastore_inequality_filters_one_property_valid_1,gae_java8_datastore_inequality_filters_one_property_invalid,gae_java8_datastore_inequality_filters_one_property_valid_2) inappengine-java8/datastore/src/test/java/com/example/appengine/QueriesTest.java.Checklist
Testing
mvn clean verifyrequiredmvn -P lint checkstyle:checkrequiredmvn -P lint clean compile pmd:cpd-check spotbugs:checkadvisory onlyCompliance & Style
pom.xmlparent set to latestshared-configurationPost-Approval Actions