Skip to content

Updated PostgreSQLDialectAdapter to correctly map specific data types…#3983

Draft
jsuhani-2026 wants to merge 8 commits into
mainfrom
jsuhani-pg-indextype-mapping
Draft

Updated PostgreSQLDialectAdapter to correctly map specific data types…#3983
jsuhani-2026 wants to merge 8 commits into
mainfrom
jsuhani-pg-indextype-mapping

Conversation

@jsuhani-2026

Copy link
Copy Markdown
Contributor

Updated PostgreSQLDialectAdapter to correctly map specific data types to their appropriate IndexTypes

@jsuhani-2026 jsuhani-2026 added the addition New feature or request label Jul 3, 2026
@codecov

codecov Bot commented Jul 3, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.33935% with 60 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.61%. Comparing base (0caed64) to head (c195675).

Files with missing lines Patch % Lines
...owmapper/provider/PostgreSQLJdbcValueMappings.java 54.38% 19 Missing and 7 partials ⚠️
...niformsplitter/range/BoundaryExtractorFactory.java 75.71% 15 Missing and 2 partials ⚠️
...rmsplitter/range/RangePreparedStatementSetter.java 77.41% 6 Missing and 1 partial ⚠️
...uniformsplitter/range/BoundarySplitterFactory.java 88.37% 2 Missing and 3 partials ⚠️
...ctadapter/postgresql/PostgreSQLDialectAdapter.java 91.17% 1 Missing and 2 partials ⚠️
...er/migrations/avro/GenericRecordTypeConvertor.java 88.23% 1 Missing and 1 partial ⚠️

❌ Your patch check has failed because the patch coverage (78.33%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #3983      +/-   ##
============================================
+ Coverage     55.68%   63.61%   +7.92%     
+ Complexity     7236     2551    -4685     
============================================
  Files          1124      535     -589     
  Lines         68447    30980   -37467     
  Branches       7721     3462    -4259     
============================================
- Hits          38116    19707   -18409     
+ Misses        27856    10245   -17611     
+ Partials       2475     1028    -1447     
Components Coverage Δ
spanner-templates 87.90% <78.33%> (+0.24%) ⬆️
spanner-import-export ∅ <ø> (∅)
spanner-live-forward-migration 89.21% <88.23%> (-0.07%) ⬇️
spanner-live-reverse-replication 83.41% <88.23%> (-0.04%) ⬇️
spanner-bulk-migration 92.09% <78.33%> (-0.38%) ⬇️
gcs-spanner-dv 89.97% <88.23%> (+1.44%) ⬆️
Files with missing lines Coverage Δ
...ort/v2/reader/io/jdbc/iowrapper/JdbcIoWrapper.java 98.10% <ø> (ø)
...io/jdbc/uniformsplitter/range/PartitionColumn.java 96.87% <100.00%> (+0.10%) ⬆️
...ort/v2/reader/io/schema/SourceColumnIndexInfo.java 82.60% <100.00%> (+10.19%) ⬆️
...ource/postgres/PostgresSrcToSpSourceConnector.java 98.97% <100.00%> (+0.04%) ⬆️
...er/migrations/avro/GenericRecordTypeConvertor.java 95.90% <88.23%> (-0.38%) ⬇️
...ctadapter/postgresql/PostgreSQLDialectAdapter.java 93.72% <91.17%> (+0.19%) ⬆️
...uniformsplitter/range/BoundarySplitterFactory.java 96.84% <88.37%> (-2.04%) ⬇️
...rmsplitter/range/RangePreparedStatementSetter.java 89.74% <77.41%> (-8.22%) ⬇️
...niformsplitter/range/BoundaryExtractorFactory.java 91.47% <75.71%> (-7.23%) ⬇️
...owmapper/provider/PostgreSQLJdbcValueMappings.java 85.32% <54.38%> (-13.89%) ⬇️

... and 613 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jsuhani-2026 jsuhani-2026 force-pushed the jsuhani-pg-indextype-mapping branch 12 times, most recently from a6cfe2f to 23b5852 Compare July 13, 2026 03:07
@jsuhani-2026 jsuhani-2026 force-pushed the jsuhani-pg-indextype-mapping branch 10 times, most recently from e71c511 to de8bb6f Compare July 14, 2026 13:17
… (BOOL, TIME, UUID, etc.) to their appropriate IndexTypes

Updated the integration tests for PostgreSQL simple primary keys to make sure primary keys of all different data types migrate successfully.
…ated method for generating primary key test rows
@jsuhani-2026 jsuhani-2026 force-pushed the jsuhani-pg-indextype-mapping branch from de8bb6f to c195675 Compare July 15, 2026 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

addition New feature or request size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant