Expose core StreamConnectionState as the public connection state (breaking)#1739
Merged
aleksandar-apostolov merged 3 commits intoJul 14, 2026
Merged
Conversation
aleksandar-apostolov
added
the
pr:breaking-change
Contributor
PR checklist ✅All required conditions are satisfied:
🎉 Great job! This PR is ready for review. |
Contributor
SDK Size Comparison 📏
|
This was referenced Jul 1, 2026
Contributor
WalkthroughThe client replaces its local ChangesConnection state unification
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant StreamClientListener
participant StreamVideoClient
participant ClientState
StreamClientListener->>StreamVideoClient: onState(StreamConnectionState)
StreamVideoClient->>ClientState: handleStreamState(state)
ClientState->>ClientState: publish connection state
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aleksandar-apostolov
force-pushed
the
gsd/phase-2-03-connectionstate-rewrite
branch
2 times, most recently
from
eda7d6c to
5b4832d
Compare
aleksandar-apostolov
force-pushed
the
gsd/phase-2-02-streamclient-rewrite
branch
from
092085e to
a632706
Compare
aleksandar-apostolov
force-pushed
the
gsd/phase-2-03-connectionstate-rewrite
branch
2 times, most recently
from
f5c9138 to
b01d2d2
Compare
aleksandar-apostolov
force-pushed
the
gsd/phase-2-02-streamclient-rewrite
branch
from
97f4003 to
fa2eeb2
Compare
aleksandar-apostolov
force-pushed
the
gsd/phase-2-03-connectionstate-rewrite
branch
5 times, most recently
from
c14482e to
5378836
Compare
aleksandar-apostolov
force-pushed
the
gsd/phase-2-02-streamclient-rewrite
branch
from
c761587 to
6ecf46f
Compare
aleksandar-apostolov
force-pushed
the
gsd/phase-2-03-connectionstate-rewrite
branch
7 times, most recently
from
c55f56f to
05ef80c
Compare
aleksandar-apostolov
changed the title
aleksandar-apostolov
force-pushed
the
gsd/phase-2-02-streamclient-rewrite
branch
from
11e6329 to
d03a473
Compare
aleksandar-apostolov
force-pushed
the
gsd/phase-2-03-connectionstate-rewrite
branch
from
393ef1f to
c05d2f7
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/ClientState.kt (1)
138-140: 📐 Maintainability & Code Quality | 🔵 Trivial | 💤 Low valueConsider adding a debug log in
handleStreamStatefor observability.The class already has a
logger(line 50). A one-line debug log would help trace connection-state transitions during development without leaking sensitive data (StreamConnectionStatecarries user IDs, not JWTs/ICE tokens).♻️ Optional: add debug log
internal fun handleStreamState(streamState: StreamConnectionState) { + logger.d { "[handleStreamState] $streamState" } _connection.value = streamState }🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/ClientState.kt` around lines 138 - 140, Add a one-line debug log at the start of ClientState.handleStreamState using the existing logger, recording the incoming StreamConnectionState to trace connection transitions without logging sensitive credentials.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In
`@stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/ClientState.kt`:
- Around line 138-140: Add a one-line debug log at the start of
ClientState.handleStreamState using the existing logger, recording the incoming
StreamConnectionState to trace connection transitions without logging sensitive
credentials.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: 3c7aa3f2-6fdc-4b6e-879d-384aef18cd9b
📒 Files selected for processing (16)
stream-video-android-core/api/stream-video-android-core.apistream-video-android-core/src/androidTest/kotlin/io/getstream/video/android/core/AndroidDeviceTest.ktstream-video-android-core/src/main/kotlin/io/getstream/video/android/core/ClientState.ktstream-video-android-core/src/main/kotlin/io/getstream/video/android/core/StreamVideoClient.ktstream-video-android-core/src/main/kotlin/io/getstream/video/android/core/socket/coordinator/v2/ConnectionStateMapper.ktstream-video-android-core/src/test/kotlin/io/getstream/video/android/core/ClientAndAuthTest.ktstream-video-android-core/src/test/kotlin/io/getstream/video/android/core/ClientStateConnectionMappingTest.ktstream-video-android-core/src/test/kotlin/io/getstream/video/android/core/ClientStateTest.ktstream-video-android-core/src/test/kotlin/io/getstream/video/android/core/StreamVideoClientTest.ktstream-video-android-core/src/test/kotlin/io/getstream/video/android/core/rtc/RtcSessionTest.ktstream-video-android-ui-xml/api/stream-video-android-ui-xml.apistream-video-android-ui-xml/src/main/kotlin/io/getstream/video/android/xml/widget/appbar/CallAppBarContent.ktstream-video-android-ui-xml/src/main/kotlin/io/getstream/video/android/xml/widget/appbar/CallAppBarView.ktstream-video-android-ui-xml/src/main/kotlin/io/getstream/video/android/xml/widget/appbar/internal/DefaultCallAppBarCenterContent.ktstream-video-android-ui-xml/src/main/kotlin/io/getstream/video/android/xml/widget/appbar/internal/DefaultCallAppBarLeadingContent.ktstream-video-android-ui-xml/src/main/kotlin/io/getstream/video/android/xml/widget/appbar/internal/DefaultCallAppBarTrailingContent.kt
💤 Files with no reviewable changes (3)
- stream-video-android-core/src/test/kotlin/io/getstream/video/android/core/ClientStateConnectionMappingTest.kt
- stream-video-android-core/src/main/kotlin/io/getstream/video/android/core/socket/coordinator/v2/ConnectionStateMapper.kt
- stream-video-android-core/api/stream-video-android-core.api
Contributor
|
Nice PR. @aleksandar-apostolov Low priority: |
Base automatically changed from
gsd/phase-2-02-streamclient-rewrite
to
develop-v2
July 13, 2026 10:23
…tate Delete the video-owned ConnectionState sealed interface instead of reshaping it into a 1:1 mirror of core's StreamConnectionState: a mirror forbidden from diverging is pure maintenance (copy + mapper + mapping tests + drift risk) with no insulation benefit, since core is already an api() dependency. The Feeds SDK sets the precedent — its FeedsClient.state exposes StreamConnectionState directly, so both core-v5 SDKs now surface the same connection state type. ClientState.connection becomes StateFlow<StreamConnectionState>, fed by handleStreamState as a plain assignment from the StreamClient listener. Delete the dead legacy paths (handleState(VideoSocketState), handleError, the ConnectedEvent branch — core consumes the auth event internally) and ConnectionStateMapper with its mapping test. XML appbar renderState signatures and the connection assertions in ClientAndAuthTest, AndroidDeviceTest and RtcSessionTest move to the core type; RtcSessionTest's assertion also switches to RealtimeConnection, the type call.state.connection actually is.
Pure deletion: the video ConnectionState surface (44 lines) leaves the dump; the public connection state now comes from stream-android-core.
The deletion-heavy diff leaves ~4 new lines, so the single uncovered one (the onState body) fails Sonar's 80% new-code gate on its own.
aleksandar-apostolov
force-pushed
the
gsd/phase-2-03-connectionstate-rewrite
branch
from
c05d2f7 to
ca4f3d9
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goal
Refs AND-1283
⚠ Breaking public API change. Removes the video-owned
ConnectionStateentirely —ClientState.connectionnow exposes core'sStreamConnectionStatedirectly, the same pattern the Feeds SDK uses (FeedsClient.state). No copy, no mapper, no drift risk.Depends on #1738 (StreamClient wiring). Merge after parent.
Implementation
ClientState.connectionbecomesStateFlow<StreamConnectionState>;handleStreamStateis a plain assignment fed by theStreamClientlistener (onState).ConnectionStatesealed interface,ConnectionStateMapper+ mapping test, and the dead legacy paths (handleState(VideoSocketState),handleError, theConnectedEventbranch — core consumes the auth event internally).renderState(...)signatures move to the core type (pass-through, no behavior change).stream-video-android-core.api; the connection-state surface now ships instream-android-core.Testing
./gradlew :stream-video-android-core:testDebugUnitTest—ClientStateTestasserts every reported core state is published unchanged;ClientAndAuthTest/AndroidDeviceTestassertions moved to the core type../gradlew apiCheck spotlessCheckSummary by CodeRabbit
Breaking Changes
Bug Fixes
Tests