eng: add lint rule requiring explicit writing connections ECOMM-11653#53
Open
tahoemph wants to merge 1 commit into
Open
eng: add lint rule requiring explicit writing connections ECOMM-11653#53tahoemph wants to merge 1 commit into
tahoemph wants to merge 1 commit into
Conversation
Adds Dutchie/RequireWritingConnection, scoped to app/services/**/queries/** and the two PlusApiKey models, to flag write calls not wrapped in connected_to(role: :writing). Bumps gem to 2.2.0.
tahoemph
requested review from
cyril-vandyke,
danhealy,
evan-waters and
zarazan-dutchie
July 15, 2026 19:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Dutchie/RequireWritingConnection, a RuboCop cop that flags AR write calls (create,save,update,destroy,touch, etc.) not wrapped inconnected_to(role: :writing).Includeinconfig/default.ymltoapp/services/**/queries/**/*.rbplusapp/models/plus_api_key.rbandapp/models/plus_enterprise_api_key.rb— the places already known to contain code reachable from GET requests (whichActiveRecord::Middleware::DatabaseSelectorroutes to a read replica by default).Testing
bundle exec rspec