feat: allow errors to be ignored for JS linting - #398
Merged
Conversation
Allows linting errors to be explicitly ignored, essentially turning them into warnings.
wilsonjord
force-pushed
the
feat-allow-lint-ignore
branch
from
July 30, 2026 22:30
163b2d6 to
a6fbbfb
Compare
ardrigh
approved these changes
Jul 31, 2026
ardrigh
left a comment
ardrigh
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Just one style comment.
Comment on lines
+21
to
+22
| ignore-errors: | ||
| type: boolean |
Contributor
There was a problem hiding this comment.
Suggested change
| ignore-errors: | |
| type: boolean | |
| ignore-errors: | |
| required: false | |
| type: boolean |
Just for consistency with the other input parameters, define required: false here as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When onboarding projects to use linting, useful to be able to suppress errors to allow builds to still be successful.
Note: even when errors are explicitly ignored by the calling workflow, we still get reporting on them:
https://github.com/GeoNet/tilde/actions/runs/30586891104