feat: add ECR authentication - #381
Draft
wilsonjord wants to merge 1 commit into
Draft
Conversation
wilsonjord
force-pushed
the
feat-allow-ecr-pull
branch
from
June 8, 2026 21:37
d3f48f2 to
ef084de
Compare
wilsonjord
marked this pull request as ready for review
June 8, 2026 21:38
wilsonjord
changed the title
wilsonjord
force-pushed
the
feat-allow-ecr-pull
branch
from
June 18, 2026 21:24
ef084de to
09b6c88
Compare
wilsonjord
force-pushed
the
feat-allow-ecr-pull
branch
from
July 30, 2026 02:06
09b6c88 to
24077ce
Compare
ardrigh
reviewed
Jul 31, 2026
Comment on lines
+2
to
+3
| env: | ||
| VERSION_CRANE: v0.16.1 |
Contributor
There was a problem hiding this comment.
Would it not be easier to test across different repos by setting the Crane version as input parameter instead of an environment variable?
Contributor
Author
There was a problem hiding this comment.
Setting crane version this way can be seen in reusable-ko-build, reusable-docker-build, reusable-container-image-scan, and even in USAGE.md. Your point may well be a good one, but it would need to be address outside of this PR I think
wilsonjord
force-pushed
the
feat-allow-ecr-pull
branch
from
July 31, 2026 01:11
24077ce to
d28b00a
Compare
wilsonjord
marked this pull request as draft
July 31, 2026 01:26
Enable `go test` to pull container images, which supports integration and e2e style testing.
wilsonjord
force-pushed
the
feat-allow-ecr-pull
branch
from
July 31, 2026 02:11
d28b00a to
92acb4b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows running tests utilising containers