Skip to content

CI: Allow Tests and Docs workflows to pass for segment fault on Windows #4664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seisman merged 3 commits into from
Jun 5, 2026
+27 −5
Merged

CI: Allow Tests and Docs workflows to pass for segment fault on Windows #4664

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
aa59acf
ci: allow Windows make segfaults
seisman Jun 4, 2026
0bc9998
Apply suggestion from @seisman
seisman Jun 4, 2026
3ef7cde
Apply suggestion from @seisman
seisman Jun 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 18 additions & 4 deletions .github/workflows/ci_docs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,8 +53,7 @@ jobs:
strategy:
fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest]
# os: [ubuntu-latest, macos-latest, windows-latest]
os: [ubuntu-latest, macos-latest, windows-latest]
# Is it a draft Pull Request (true or false)?
isDraft:
- ${{ github.event.pull_request.draft }}
Expand Down Expand Up @@ -136,10 +135,25 @@ jobs:
python -m pip install dist/*

- name: Build the HTML documentation
run: make -C doc clean html
run: |
log_file="${RUNNER_TEMP}/sphinx-html.log"
make -C doc clean html 2>&1 | tee "${log_file}"
exit_code=${PIPESTATUS[0]}
if [[ "${RUNNER_OS}" == "Windows" && "${exit_code}" -eq 2 ]] && grep -q "make: .* Error 2816" "${log_file}"; then

@seisman seisman Jun 4, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make returns error code 2 with error message "Error 2816".

echo "Sphinx HTML build exited with make error 2816 (segmentation fault) on Windows; allowing workflow to continue."
exit 0
fi
exit "${exit_code}"

- name: Build the PDF documentation
run: make -C doc pdf
run: |
log_file="${RUNNER_TEMP}/sphinx-latex.log"
make -C doc latex 2>&1 | tee "${log_file}"
exit_code=${PIPESTATUS[0]}
if [[ "${RUNNER_OS}" == "Windows" && "${exit_code}" -eq 2 ]] && grep -q "make: .* Error 2816" "${log_file}"; then
echo "Sphinx LaTeX build exited with make error 2816 (segmentation fault) on Windows; allowing workflow to continue."
Comment thread
seisman marked this conversation as resolved.
exit 0
fi

- name: Create the HTML ZIP archive and rename the PDF file
run: |
Expand Down
10 changes: 9 additions & 1 deletion .github/workflows/ci_tests.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,15 @@ jobs:

# Run the regular tests
- name: Run tests
run: make test PYTEST_EXTRA="-r P --reruns 2"
run: |
log_file="${RUNNER_TEMP}/pytest.log"
make test PYTEST_EXTRA="-r P --reruns 2" 2>&1 | tee "${log_file}"
exit_code=${PIPESTATUS[0]}
if [[ "${RUNNER_OS}" == "Windows" && "${exit_code}" -eq 2 ]] && grep -q "make: .* Error 2816" "${log_file}"; then
echo "Tests exited with make error 2816 (segmentation fault) on Windows; allowing workflow to continue."
exit 0
fi
exit "${exit_code}"

# Upload diff images on test failure
- name: Upload diff images if any test fails
Expand Down
Loading