Fix error when callr option default is NULL#93
Merged
Conversation
Dev callr (about to be submitted to CRAN) has changed the default value of one of its options to `NULL`. This makes the checked package fail `R CMD check`. This PR fixes that. `NULL != bquote()` returns `logical(0)` instead of `TRUE`, causing `vapply()` to error. Use `!identical(x, bquote())` which correctly returns a scalar logical for any value including NULL.
Collaborator
|
Thanks for the fix and letting us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dev callr (about to be submitted to CRAN) has changed the default value of one of its options to
NULL. This makes the checked package failR CMD check. This PR fixes that.NULL != bquote()returnslogical(0)instead ofTRUE, causingvapply()to error. Use!identical(x, bquote())which correctly returns a scalar logical for any value including NULL.