Skip to content

[GFX-212] 重命名 InternalXxHashHelper 公开方法消除 Sonar S3218 遮蔽 - #119

Merged
AlianBlank merged 2 commits into
mainfrom
feature/GFX-212
Aug 5, 2026
Merged

[GFX-212] 重命名 InternalXxHashHelper 公开方法消除 Sonar S3218 遮蔽#119
AlianBlank merged 2 commits into
mainfrom
feature/GFX-212

Conversation

@AlianBlank

@AlianBlank AlianBlank commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Linear: GFX-212

Summary by CodeRabbit

  • 变更
    • 重命名 32 位哈希计算接口为 ComputeHash32,支持字节数组、字符串、类型及泛型调用。
    • 重命名 64 位哈希计算接口为 ComputeHash64,支持字节数组、字符串、类型及泛型调用。
    • 哈希计算逻辑保持不变;使用旧接口的调用方需要更新方法名称。

@linear-code

linear-code Bot commented Jul 30, 2026

Copy link
Copy Markdown

GFX-212

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a72d86b1-8de3-40e2-ab90-e8d906f4ad66

📥 Commits

Reviewing files that changed from the base of the PR and between cdda9f0 and 99dfb86.

📒 Files selected for processing (1)
  • GameFrameX.Foundation.Hash/XxHashHelper.cs
🚧 Files skipped from review as they are similar to previous changes (1)
  • GameFrameX.Foundation.Hash/XxHashHelper.cs

📝 Walkthrough

Walkthrough

该变更将 InternalXxHashHelper 的 32 位和 64 位入口统一重命名为 ComputeHash32ComputeHash64,并更新 XxHashHelper 的 Type 与泛型入口调用。底层哈希计算逻辑未改变。

Changes

xxHash 入口重命名

Layer / File(s) Summary
内部计算入口重命名
GameFrameX.Foundation.Hash/XxHashHelper.cs
InternalXxHashHelper 的字节数组、字符串、Type 和泛型 32 位、64 位入口改名为 ComputeHash32ComputeHash64,并同步更新内部调用。
外部入口调用更新
GameFrameX.Foundation.Hash/XxHashHelper.cs
XxHashHelper 的 Type 与泛型入口改为调用对应的 InternalXxHashHelper.ComputeHash32ComputeHash64 方法。

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive 标题仅包含 issue 编号和通用的 feature 标识,未说明本次重命名 XxHashHelper API 的主要变更。 请将标题改为明确描述主要变更的单句,例如“[GFX-212] 重命名 XxHashHelper 哈希计算 API”。
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/GFX-212

Comment @coderabbitai help to get the list of available commands.

# Conflicts:
#	GameFrameX.Foundation.Hash/XxHashHelper.cs
@sonarqubecloud

sonarqubecloud Bot commented Aug 5, 2026

Copy link
Copy Markdown

@AlianBlank
AlianBlank merged commit 5cc9306 into main Aug 5, 2026
2 checks passed
@AlianBlank
AlianBlank deleted the feature/GFX-212 branch August 5, 2026 03:11
@AlianBlank AlianBlank changed the title [GFX-212] feature/GFX-212 [GFX-212] 重命名 InternalXxHashHelper 公开方法消除 Sonar S3218 遮蔽 Aug 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant