Skip to content

Fix hang-glider falldamage#53

Open
MassAnarchyy wants to merge 2 commits into
GTNewHorizons:masterfrom
MassAnarchyy:fix/hangglider-fall-damage
Open

Fix hang-glider falldamage#53
MassAnarchyy wants to merge 2 commits into
GTNewHorizons:masterfrom
MassAnarchyy:fix/hangglider-fall-damage

Conversation

@MassAnarchyy

@MassAnarchyy MassAnarchyy commented Jun 9, 2026

Copy link
Copy Markdown
Member

fixes GTNewHorizons/GT-New-Horizons-Modpack#25168

Removes 1 simple line to re-enable fall damage from unequipping glider while flying but having glider in said hand

@MassAnarchyy MassAnarchyy requested review from a team and UltraProdigy and removed request for UltraProdigy June 9, 2026 18:18
@tiffit

tiffit commented Jun 10, 2026

Copy link
Copy Markdown
Member

Does the player take fall damage while still gliding?

@MassAnarchyy

MassAnarchyy commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

@tiffit thank you <3 Just got changes up with a simple falldamagehandler listening for fall event -- if glider is actively deployed event is cancelled so no fall damage

Edit: accumulation 🤦‍♂️ , converted to draft for moment while I work on fixing

@MassAnarchyy MassAnarchyy marked this pull request as draft June 10, 2026 17:11
@MassAnarchyy MassAnarchyy force-pushed the fix/hangglider-fall-damage branch from f1ed823 to bce7f43 Compare June 10, 2026 19:20
@MassAnarchyy MassAnarchyy marked this pull request as ready for review June 10, 2026 19:44
@MassAnarchyy

MassAnarchyy commented Jun 10, 2026

Copy link
Copy Markdown
Member Author

@tiffit
Okay, reverted earlier attempts, Tested in dev and it's working correctly now

the issue was that right-click while gliding to undeploy was sometimes hitting the wrong glider because the client and server weren’t pointing at the same instance, This caused the server-side glider to stay alive and keep looping onUpdate which kept resetting fall damage, Now it directly finds the active glider entity before calling setDead(), so the correct one is removed and the loop stops properly :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OpenBlocks HangGlider causes no fall damage while held

2 participants