Skip to content

GPII-1898: Update to node 6#84

Merged
amb26 merged 4 commits into
GPII:masterfrom
javihernandez:GPII-1898
Sep 27, 2016
Merged

GPII-1898: Update to node 6#84
amb26 merged 4 commits into
GPII:masterfrom
javihernandez:GPII-1898

Conversation

@javihernandez

@javihernandez javihernandez commented Aug 13, 2016

Copy link
Copy Markdown
Member

This isn't ready yet until these two issues are solved:

Can be tested by applying the following patch: NO LONGER NEEDED

diff --git a/package.json b/package.json
index 3a8ea2b..7df85a8 100644
--- a/package.json
+++ b/package.json
@@ -10,7 +10,9 @@
         "ref": "1",
         "ref-struct": "1",
         "ref-array": "1.1.2",
-        "universal": "gpii/universal#98561d07c0b49d4d565be9027adebf36c1d1fe82"
+        "universal": "gpii/universal#98561d07c0b49d4d565be9027adebf36c1d1fe82",
+        "nan": "amatas/nan#bbe2ba05648320ce19646e2ceab9c840cd59583e",
+        "infusion": "javihernandez/infusion#77c3abb599648635fad3870bce8702411b677ca7"
     },
     "devDependencies": {
         "grunt": "1.0.1",

I'm intentionally bumping the minimum node version required to 6.* because we need npm 3 to avoid this problem.

@gpii-bot

Copy link
Copy Markdown

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

@gloob

gloob commented Aug 25, 2016

Copy link
Copy Markdown
Member

ok to test

1 similar comment
@colinbdclark

Copy link
Copy Markdown
Member

ok to test

@gpii-bot

Copy link
Copy Markdown

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

@amb26

amb26 commented Sep 3, 2016

Copy link
Copy Markdown
Member

@gloob - there's a fix in Infusion core now for FLUID-5940 but https://issues.gpii.net/browse/GPII-1994 is now a new blocker assigned to @kaspermarkus

@gpii-bot

gpii-bot commented Sep 9, 2016

Copy link
Copy Markdown

CI job failed. Please visit http://lists.gpii.net/pipermail/ci/ for more details.

@javihernandez

javihernandez commented Sep 9, 2016

Copy link
Copy Markdown
Member Author

I've updated this with current master to avoid conflicts.

The current status of the blockers we have is the following:

BTW, I've reverted the minimum required version of node in universal and linux BUT since we're having this particular problem with windows, I recommend to keep the node version requirement to 6.x so users don't need to manually update npm to get it working with node 4.x.

* upstream/master:
  GPII-1108: Merged up with master
  GPII-1540: Fixed indentation.
  GPII-1540: Make test-window.exe build automatically
  GPII-1540: Removed the test application executable
  GPII-1540: Flipped options.force to option.cleanOnly. Off by default feels better.
  GPII-1540: Unit tests for closeProcessByName always pass Waiting for process start sometimes triggers just before the window is created.
  GPII-1540: Unit tests for closeProcessByName Created test-window, a dummy application that creates a window for testing.
  GPII-1540: rollback; Put findProcessByName back to how it was. It turned out to be better to enumerate the windows, rather than enumerate every thread.
  GPII-1540: Made the process enumeration in findProcessByName re-usable. Refactored it out into eachProcess, in preparation for a "get the windows of each process" routine.
  GPII-1540: Merge from master
  GPII-1540: Implemented closeProcessByName. Terminate a process less aggressively.
  GPII-1828: Allows for retrieval of updated env vars
  GPII-1108: Fixed logic for allowing deletion of subkeys of nonexistent parents in the registry to be a noop
@gpii-bot

Copy link
Copy Markdown

CI job passed.

@javihernandez

Copy link
Copy Markdown
Member Author

I've updated the reference to universal and added nan as dependency. I've also created an issue (https://issues.gpii.net/browse/GPII-2037) to remove our dependency with nan when the issue we have is fixed upstream.

@amb26 amb26 merged commit 6a1d8fd into GPII:master Sep 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants