GPII-2653: Initial onboarding of the PSP - starting with just the language setting#606
GPII-2653: Initial onboarding of the PSP - starting with just the language setting#606amb26 wants to merge 2 commits into
Conversation
|
CI job passed: https://ci.gpii.net/job/universal-tests/825/ |
|
ok to test |
|
CI job failed: https://ci.gpii.net/job/universal-tests/880/ |
|
@amb26 I think you just need to merge scripts/vagrantCloudBasedContainers.sh because the repository name for the preferences loader might have changed. Otherwise the build looks okay. |
|
CI job failed: https://ci.gpii.net/job/universal-tests/885/ |
|
Failed due to https://issues.gpii.net/browse/GPII-3094, trying again |
|
ok to test |
|
CI job passed: https://ci.gpii.net/job/universal-tests/887/ |
javihernandez
left a comment
javihernandez
left a comment
There was a problem hiding this comment.
Beyond the two comments I just provided, this is looking great.
In addition to this, we need to add:
- Tests
- A description of the solution
- An np set that one can use to test this functionality
| "http://registry.gpii.net/common/supportTool": ["dictionary"] | ||
| }, | ||
| "http://registry.gpii.net/applications/net.gpii.psp": { | ||
| "http://registry.gpii.net/common/language": "en" |
| "path": "net.gpii.psp" | ||
| }, | ||
| "supportedSettings": { | ||
| "language": {}, |
There was a problem hiding this comment.
Don't we need to include the metadata for this settitng? I guess that we want it to be there if we want to get it rendered in the PSP.
There was a problem hiding this comment.
Also in order to support editing it in the PPT
6 participants
No description provided.