Skip to content

fix(external-sources): i18n, alignment, and visual polish for config UI#1760

Merged
limityan merged 2 commits into
GCWing:mainfrom
limityan:fix/external-sources-ui-polish
Jul 25, 2026
Merged

fix(external-sources): i18n, alignment, and visual polish for config UI#1760
limityan merged 2 commits into
GCWing:mainfrom
limityan:fix/external-sources-ui-polish

Conversation

@limityan

Copy link
Copy Markdown
Collaborator

Summary

Fixes multiple i18n, alignment, and visual clarity issues in the External AI Applications settings page.

Changes

Bug fixes

  • Ecosystem mode Select not closing: When the master toggle is off, ecosystem mode dropdowns still showed the previous value instead of "disabled". Now maps to disabled when the master toggle is off, matching capability access behavior.
  • Raw English diagnostic messages leaking to UI: Hook diagnostics, source diagnostics, and operation errors showed raw backend English strings. Removed all raw diagnostic.message rendering; only show the i18n category text.
  • Raw diagnostic codes shown to users: Codes like opencode_default_permission_semantics_not_imported were displayed inline. Removed from all rendering locations.

Structural changes

  • Removed ExternalHooksPanel from page (read-only, no decision impact)
  • Moved policy/master toggle to top of page
  • Removed catalog-level diagnostics section (redundant with per-source)
  • Filtered info-severity hook diagnostics (not actionable)
  • Flattened agent diagnostics: no nested collapsible, only show nextStep for blocking items

i18n improvements (zh-CN / en-US / zh-TW)

  • Rewrote all hook diagnostic texts — removed jargon
  • Rewrote all agent diagnostic texts — shorter, plain language
  • Rewrote MCP empty state — removed incomplete JSON example, clarified purpose
  • Added operationErrors.errorCode and hooks.diagnosticCode keys

Visual polish

  • Removed gray box backgrounds that looked muddy in light theme
  • Added chevron indicators to all expandable details areas
  • Added left-border grouping and top-border separators
  • Fixed alignment: all content shares same left edge within sections
  • Fixed chevron-text spacing
  • Cleaned up unused SCSS rules

Verification

Command Result
pnpm run type-check:web Pass
pnpm run i18n:audit Pass (0 warnings)
pnpm run theme:color-audit:all Pass
ExternalSourcesConfig tests 47/47 pass
ExternalHooksPanel tests 13/13 pass

limityan added 2 commits July 25, 2026 18:00
- Fix ecosystem mode Select not showing disabled when master toggle is off
- Remove raw English diagnostic messages from hook and source diagnostics
- Replace raw error.detail with localized code reference
- Add chevron indicators to all expandable <details> areas
- Remove ExternalHooksPanel from page (read-only, no decision impact)
- Move policy/master toggle to top of page
- Remove catalog-level diagnostics section (redundant with per-source)
- Filter out info-severity hook diagnostics (not actionable)
- Flatten agent diagnostics: remove raw code, only show nextStep for blocking
- Remove raw diagnostic code from agent detail and conflict cards
- Rewrite all hook diagnostic texts for clarity (remove jargon)
- Rewrite agent diagnostic texts (shorter, plain language)
- Rewrite MCP empty state (remove incomplete example, clarify purpose)
- Remove gray box backgrounds that look muddy in light theme
- Add left-border grouping and top-border separators for visual structure
- Fix alignment: all content shares same left edge within sections
- Fix chevron-text spacing (gap + margin-right was too large)
- Clean up unused SCSS (technical-detail, catalog-diagnostics, etc.)
- Delete ExternalHooksPanel component, SCSS, and tests (dead code after
  removing from page; no other consumers)
- Remove unused hooks.diagnosticCode key from all three locales
- Remove unused mcp.emptyExample key from all three locales
- Resolves repeated filter() call (was in deleted ExternalHooksPanel)
@limityan
limityan merged commit b791b81 into GCWing:main Jul 25, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant