fix(external-sources): deduplicate configuration source presentation#1646
Merged
limityan merged 1 commit intoJul 20, 2026
Merged
Conversation
limityan
force-pushed
the
yanzhn/fix-external-source-presentation
branch
from
July 20, 2026 09:33
a514653 to
f6a0fdc
Compare
limityan
marked this pull request as ready for review
July 20, 2026 09:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility and risk
presentationGroupIdis optional, omitted when absent, and accepts legacy snapshots without the field.Validation
pnpm --dir src/web-ui run test:run src/infrastructure/config/externalSourcePresentation.test.ts src/infrastructure/config/components/ExternalSourcesConfig.test.tsx(48 passed)pnpm run type-check:webpnpm run lint:web(0 errors; 13 existing warnings outside this change)cargo test -p bitfun-opencode-adapter --test opencode_subagent_adapter(5 passed)cargo test -p bitfun-product-domains --features product-full --test external_source_contracts presentation_group_id_is_optional_and_uses_the_camel_case_wire_namecargo test -p bitfun-core presentation_groups_are_assigned_before_location_redaction --libcargo check -p bitfun-core --features product-fullnode scripts/check-core-boundaries.mjspnpm run check:repo-hygienegit diff --check gcwing/main...HEADIndependent review
A fresh architect review and a fresh product/UX review were completed after the implementation changes. Both found no remaining P0/P1; the product re-review also confirmed all follow-up P2 items were closed.