Preserve PyTorch autograd in partially wrapped normal PDFs - #5252
Open
FlorianPfaff wants to merge 2 commits into
Open
Preserve PyTorch autograd in partially wrapped normal PDFs#5252FlorianPfaff wants to merge 2 commits into
FlorianPfaff wants to merge 2 commits into
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
August 7, 2026 17:55
FlorianPfaff
enabled auto-merge (squash)
August 7, 2026 17:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
PartiallyWrappedNormalDistribution.pdf(...)evaluated every wrapped Gaussian image throughscipy.stats.multivariate_normal.When the active backend is PyTorch and query points require gradients, SciPy attempts to convert the tensor to NumPy. This raises:
Even for tensors without gradients, the SciPy boundary discards the active backend's dtype, device, and differentiation semantics before converting the result back.
Fix
Evaluate the Gaussian images through PyRecEst's existing backend-native
GaussianDistribution.pdf(...)implementation. The wrapping, truncation order, covariance, and summation logic remain unchanged.This uses SciPy for the NumPy backend,
torch.distributions.MultivariateNormalfor PyTorch, andjax.scipy.stats.multivariate_normalfor JAX through the established Gaussian implementation.Regression coverage
Add a PyTorch-backend regression that:
requires_grad=True;Validation
main(f196ec41d1d8681e279936db9f1a0a3abfa276e7);