Avoid overflow when validating SO(3) product particles - #5241
Open
FlorianPfaff wants to merge 1 commit into
Open
Avoid overflow when validating SO(3) product particles#5241FlorianPfaff wants to merge 1 commit into
FlorianPfaff wants to merge 1 commit into
Conversation
Use a componentwise nonzero check before the existing scale-first quaternion normalizer, and cover extreme finite quaternion inputs with a regression test.
FlorianPfaff
force-pushed
the
agent/fix-so3-product-extreme-quaternion-normalization
branch
from
August 6, 2026 06:46
e5d27e0 to
13c1e1e
Compare
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
August 7, 2026 17:58
FlorianPfaff
enabled auto-merge (squash)
August 7, 2026 17:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Bug
SO3ProductParticleFilter._as_particle_arraychecked whether a quaternion was nonzero usinglinalg.norm. For a valid finite quaternion such as[float_max / 2, float_max / 2, 0, 0], the intermediate sum of squares overflows. Under strict NumPy floating-point handling this raises before PyRecEst's existing overflow-safenormalize_quaternionshelper can run.The quaternion's scale is irrelevant to the represented rotation, so rejecting it is incorrect.
Fix
Use a componentwise nonzero predicate for validation. This avoids squaring the input and leaves normalization to the existing scale-first helper.
Validation
FloatingPointError: overflow encountered in multiply[1/sqrt(2), 1/sqrt(2), 0, 0]with unit norm under strict floating-point settings