Preserve CLEAR tracker identity precision - #5235
Open
FlorianPfaff wants to merge 3 commits into
Open
Conversation
Contributor
✅MegaLinter analysis: Success
Notices📣 MegaLinter 9.5.0 is out! Discover the new features and security recommendations in the release announcement. (Skip this info by defining See detailed reports in MegaLinter artifacts Your project could benefit from a custom flavor, which would allow you to run only the linters you need, and thus improve runtime performances. (Skip this info by defining
|
FlorianPfaff
marked this pull request as ready for review
August 7, 2026 17:59
FlorianPfaff
enabled auto-merge (squash)
August 7, 2026 18:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Bug
evaluate_clear(...)stored previous tracker identities in floating-point arrays solely to useNaNas the unmatched sentinel.Exact integer tracker IDs above the binary64 precision boundary can therefore collapse to the same stored value. For example, tracker ID
2**53 + 1is stored as2**53; a subsequent match to the genuinely different tracker ID2**53is then treated as the same identity. This also gives the wrong immediate-timestep continuity bonus and suppresses a real CLEAR identity switch.Fix
-1as the unmatched sentinel, which is safe because validated tracker identities are non-negative;Regression coverage
Add a focused two-frame sequence that changes from tracker ID
2**53 + 1to2**53. The CLEAR evaluator must report two true positives and one identity switch.Validation
2**53 + 1rounds to2**53in the float sentinel array and the switch count is incorrectly zero;main;GitHub Actions is the authoritative full repository, backend, lint, packaging, documentation, and integration validation.