fix(eval): handle variable retrieval depths in MKQA recall - #1590
Open
BingH225 wants to merge 1 commit into
Open
fix(eval): handle variable retrieval depths in MKQA recall#1590BingH225 wants to merge 1 commit into
BingH225 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
evaluate_qa_recallcurrently initializes its recall buckets using only thefirst query's context count. If a later query has more retrieved contexts and
its first answer occurs beyond that initial depth, the hit is silently omitted.
For example, with retrieval depths
[1, 2]and the second query matching atrank 2, the previous implementation returns:
The expected
Recall@1andRecall@2values are:Testing
test_evaluate_qa_recall_supports_variable_retrieval_depths.git diff --checkand targetedcodespellpassed.The complete pytest invocation was not run locally because the available
Python environment does not include FlagEmbedding's
torchdependency.