Skip to content

issue-137-User-Deletion-feature#422

Open
Saishiva3000 wants to merge 1 commit into
FindFirst-Development:mainfrom
Saishiva3000:issue-137-userDeletion-feature
Open

issue-137-User-Deletion-feature#422
Saishiva3000 wants to merge 1 commit into
FindFirst-Development:mainfrom
Saishiva3000:issue-137-userDeletion-feature

Conversation

@Saishiva3000

Copy link
Copy Markdown

Issue number: resolves #137

              ## What is the current behavior ?  ---->  User cannot delete account



              ## What is the new behavior? ------> added a end point to delete user in **UserController** and added integration   
                                                                             tests in  **UserControllerTest**>

Note:

the thing i cannot run the application on my laptop because of time zone error of postgres and i can't possibly run i don't know why , i can't solve that issue

please run tests before merging my pleased request (test is correct)

@R-Sandor

Copy link
Copy Markdown
Collaborator

What is this timezone error? This may be a bigger region/date format issue that I didn't consider, i.e. people in X country represent DateTime differently or is it just a version of postgres container that doesn't work with arm or something similar?

@Saishiva3000

Copy link
Copy Markdown
Author

the issue i got is that the postgres container could not start because the timezone error , i asked ai about this error it said something like the jvm is configuring timezone as India/calcutta which postgres won't support.

check out the code once , there are already some methods written in bookmark and tag service which i used to delete user bookmarks and tags.

another issue is about the tokens , did you make the cascade delete for tokens like when user deletes all the tokens also delete or they expire on ttl logic and get deleted

@R-Sandor

R-Sandor commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

Did you have problems trying to build it?

    Description:

    The dependencies of some of the beans in the application context form a cycle:

       bookmarkController defined in file [/home/rsandor/repos/FindFirst/FindFirst-core/server/build/classes/java/main/dev/findfirst/core/controller/BookmarkController.class]
    ┌─────┐
    |  bookmarkService defined in file [/home/rsandor/repos/FindFirst/FindFirst-core/server/build/classes/java/main/dev/findfirst/core/service/BookmarkService.class]
    ↑     ↓
    |  tagService defined in file [/home/rsandor/repos/FindFirst/FindFirst-core/server/build/classes/java/main/dev/findfirst/core/service/TagService.class]
    ↑     ↓
    |  userManagementService defined in file [/home/rsandor/repos/FindFirst/FindFirst-core/server/build/classes/java/main/dev/findfirst/users/service/UserManagementService.class]
    └─────┘

I have been tempted to prohibit the use AI on FindFirst because I end up doing more testing than reviewing, So I am slow to review.

I understand the Postgres container had issues but this error is with Java code build, entirely unrelated.

As for the Postgres time format you should have learned how to resolve those to and put in a contribution for contributors located in India to leverage. What's strange about that is I have had many contributors from India, and they never had issues.

@R-Sandor

R-Sandor commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

I would write a custom repo query that is delete tag user_id, and in turn deletes the join table entries. That would get rid of the bookmarkService dependency.

@Saishiva3000

Copy link
Copy Markdown
Author

sorry for the delay , i am into some college work. i can see the issue. i never thought circular dependency would be the issue.
i have never seen the bookmark service(sorry my fault);

can i directly add bookmark repositories dependencies to userService as you suggested.

i thought of doing this at first but i thought most would not expose their repos directly to other modules rather they do it through services so , i shifted to that side.

yeah the postgres error i don't know till now how to solve it. i will retry again , all my applications are working fine though. i will do the work if it's ok with you to add dependencies of repos to the userService

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User can delete account

2 participants