Skip to content

docs: clarify primary type labels are issues-only (PRs use ownership labels) (#35)#36

Merged
SamuelHassine merged 1 commit into
mainfrom
chore/labels-pr-clarification
Jun 7, 2026
Merged

docs: clarify primary type labels are issues-only (PRs use ownership labels) (#35)#36
SamuelHassine merged 1 commit into
mainfrom
chore/labels-pr-clarification

Conversation

@SamuelHassine

Copy link
Copy Markdown
Member

Summary

Clarifies the shared label taxonomy so it can never be misread (by a human or an automated reviewer):

  • Primary type labels (feature / bug / documentation) are applied to issues only, alongside the GitHub issue Type.
  • Pull requests do not carry a primary type label — the type: title prefix conveys the type. PRs should instead carry an ownership label (filigran team / community) to differentiate the author, plus any useful area/workflow labels.

Updated .github/LABELS.md, .github/labels.yml, and the CONTRIBUTING conventions block.

Closes #35

@SamuelHassine SamuelHassine merged commit 3b45b8d into main Jun 7, 2026
@SamuelHassine SamuelHassine deleted the chore/labels-pr-clarification branch June 7, 2026 20:58
@SamuelHassine SamuelHassine added the filigran team Item from the Filigran team. label Jun 7, 2026
@SamuelHassine

Copy link
Copy Markdown
Member Author

🤖 [AI-generated]

Hey @SamuelHassine! 👋 I'm Sam, your convention guardian. I've reviewed PR #36 and here's a summary of what I checked and adjusted:


🏷️ Labels

Action Label Reason
✅ Added filigran team Ownership label for an org-member contribution. Per .github/LABELS.md §2–§3, PRs carry an ownership label instead of a primary type label.

(No primary type label added or removed — documentation is issue-only, and the docs: title prefix already conveys the type.)


📋 PR Description Quality

Overall: Good 🎉

Your PR description looks complete and well-structured. Great job! 🎉

Clear Summary, itemized clarification of the label taxonomy, the exact files touched (.github/LABELS.md, .github/labels.yml, CONTRIBUTING), and a Closes #35 issue link. A docs-only change needs no test evidence.


💡 Title was already fully compliant — valid docs: type, lowercase imperative verb "clarify", no trailing period, and the required (#35) issue reference. Nice work! For future PRs, please keep following the contribution conventions.

Thanks for contributing! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team Item from the Filigran team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: clarify primary type labels are issues-only (PRs use ownership labels)

1 participant